Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbbKMNmW (ORCPT ); Fri, 13 Nov 2015 08:42:22 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:47212 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbKMNmV (ORCPT ); Fri, 13 Nov 2015 08:42:21 -0500 X-IronPort-AV: E=Sophos;i="5.20,287,1444694400"; d="scan'208";a="317924048" Message-ID: <5645E868.30706@citrix.com> Date: Fri, 13 Nov 2015 13:40:56 +0000 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Stefano Stabellini , CC: , , Subject: Re: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 References: <1447349448-22610-2-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1447349448-22610-2-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1926 Lines: 57 Hi Stefano, On 12/11/15 17:30, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > > --- > > Changes in v2: > - rename dom0_op to platform_op > --- > arch/arm/include/asm/xen/hypercall.h | 2 ++ > arch/arm/xen/enlighten.c | 1 + > arch/arm/xen/hypercall.S | 1 + > arch/arm64/xen/hypercall.S | 1 + > 4 files changed, 5 insertions(+) > > diff --git a/arch/arm/include/asm/xen/hypercall.h b/arch/arm/include/asm/xen/hypercall.h > index 712b50e..c3e00d0 100644 > --- a/arch/arm/include/asm/xen/hypercall.h > +++ b/arch/arm/include/asm/xen/hypercall.h > @@ -35,6 +35,7 @@ > > #include > #include > +#include > > long privcmd_call(unsigned call, unsigned long a1, > unsigned long a2, unsigned long a3, > @@ -49,6 +50,7 @@ int HYPERVISOR_memory_op(unsigned int cmd, void *arg); > int HYPERVISOR_physdev_op(int cmd, void *arg); > int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args); > int HYPERVISOR_tmem_op(void *arg); > +int HYPERVISOR_platform_op(void *arg); int HYPERVISOR_platform_op(struct xen_platform_op *platform_op) to allow compiler type checking and match the x86 version. Also, the implementation of the helper differ from x86. On x86, the helper takes care of setting the interface_version while here you request the caller to do it. It's better if we have similar requirement across the architecture as this helpers may be called from common code. > int HYPERVISOR_multicall(struct multicall_entry *calls, uint32_t nr); > > static inline int Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/