Date: Fri, 13 Nov 2015 09:01:15 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Rik van Riel <riel@redhat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        jmarchan@redhat.com, mgorman@techsingularity.net,
        willy@linux.intel.com, linux-kernel <linux-kernel@vger.kernel.org>,
        linux-mm@kvack.org
Subject: Re: [PATCH V4] mm: fix kernel crash in khugepaged thread
Message-ID: <20151113090115.1ad4235b@gandalf.local.home>
In-Reply-To: <D7E480F5-D879-4016-B530-5A4D7CB05675@gmail.com>
References: <1447316462-19645-1-git-send-email-yalin.wang2010@gmail.com>
	<20151112092923.19ee53dd@gandalf.local.home>
	<5645BFAA.1070004@suse.cz>
	<D7E480F5-D879-4016-B530-5A4D7CB05675@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1067
Lines: 36

On Fri, 13 Nov 2015 19:54:11 +0800
yalin wang <yalin.wang2010@gmail.com> wrote:

> >>>  	TP_fast_assign(
> >>>  		__entry->mm = mm;
> >>> -		__entry->pfn = pfn;
> >>> +		__entry->pfn = page_to_pfn(page);  
> >> 
> >> Instead of the condition, we could have:
> >> 
> >> 	__entry->pfn = page ? page_to_pfn(page) : -1;  
> > 
> > I agree. Please do it like this.  

hmm, pfn is defined as an unsigned long, would -1 be the best.
Or should it be (-1UL).

Then we could also have:

        TP_printk("mm=%p, scan_pfn=0x%lx%s, writable=%d, referenced=%d, none_or_zero=%d, status=%s, unmapped=%d",
                __entry->mm,
                __entry->pfn == (-1UL) ? 0 : __entry->pfn,
		__entry->pfn == (-1UL) ? "(null)" : "",

Note the added %s after %lx I have in the print format.

-- Steve


> ok ,  i will send V5 patch .
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/