Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754921AbbKMOpF (ORCPT ); Fri, 13 Nov 2015 09:45:05 -0500 Received: from mail.kernel.org ([198.145.29.136]:48157 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754632AbbKMOpD (ORCPT ); Fri, 13 Nov 2015 09:45:03 -0500 Date: Fri, 13 Nov 2015 08:44:57 -0600 From: Rob Herring To: huangdaode Cc: davem@davemloft.net, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, dingtianhong@huawei.com, zhangfei.gao@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com Subject: Re: [PATCH] net: hisilicon: fix binding document of mdio Message-ID: <20151113144457.GA18563@rob-hp-laptop> References: <1447381424-107248-1-git-send-email-huangdaode@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447381424-107248-1-git-send-email-huangdaode@hisilicon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1844 Lines: 47 On Fri, Nov 13, 2015 at 10:23:44AM +0800, huangdaode wrote: > This patch fixes explain the occasion of "hisilcon,mdio" according to > Arnd's comments. specify it is only used for hip04. > > First, please give your commnents. > > Signed-off-by: huangdaode > --- > Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > index 9c23fdf..f650e78 100644 > --- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > @@ -1,7 +1,9 @@ > Hisilicon MDIO bus controller > > Properties: > -- compatible: "hisilicon,mdio","hisilicon,hns-mdio". > +- compatible: can be one of "hisilicon,hns-mdio","hisilicon,mdio", > + for hip04 board, please use "hisilicon,mdio", > + other boards, "hisilicon,hns-mdio" is OK. Please reformat like this: - compatible: can be one of: "hisilicon,hns-mdio" "hisilicon,mdio" For hip04 board, must be "hisilicon,mdio". Otherwise, must be "hisilicon,hns-mdio". > - reg: The base address of the MDIO bus controller register bank. > - #address-cells: Must be <1>. > - #size-cells: Must be <0>. MDIO addresses have no size component. > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/