Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754919AbbKMPuL (ORCPT ); Fri, 13 Nov 2015 10:50:11 -0500 Received: from mail.kernel.org ([198.145.29.136]:52388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754647AbbKMPuJ (ORCPT ); Fri, 13 Nov 2015 10:50:09 -0500 Date: Fri, 13 Nov 2015 12:50:04 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: masami.hiramatsu.pt@hitachi.com, ast@kernel.org, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/12] perf probe: Clear probe_trace_event when add_probe_trace_event() fails Message-ID: <20151113155004.GM7160@kernel.org> References: <1447417761-156094-1-git-send-email-wangnan0@huawei.com> <1447417761-156094-3-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447417761-156094-3-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 17 Em Fri, Nov 13, 2015 at 12:29:11PM +0000, Wang Nan escreveu: > When probe with glob, error in add_probe_trace_event() won't be passed > to debuginfo__find_trace_events() because it whould be modified by > probe_point_search_cb(). It causes segfault if perf failed to find > argument for one probing point matched by the glob. For example: I applied the first two patches in this series, after testing them by following the before/after instructions, thank you for providing it! I'm now going from patch 6 onwards, just FYI. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/