Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933217AbbKMR2u (ORCPT ); Fri, 13 Nov 2015 12:28:50 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33645 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754364AbbKMR2r (ORCPT ); Fri, 13 Nov 2015 12:28:47 -0500 Message-ID: <56461DCD.4020701@linaro.org> Date: Fri, 13 Nov 2015 09:28:45 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Z Lim CC: Alexei Starovoitov , daniel@iogearbox.net, Catalin Marinas , Will Deacon , Xi Wang , LKML , Network Development , "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org Subject: Re: [PATCH 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS References: <1447365421-1309-1-git-send-email-yang.shi@linaro.org> <1447365421-1309-3-git-send-email-yang.shi@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 50 On 11/12/2015 7:28 PM, Z Lim wrote: > On Thu, Nov 12, 2015 at 1:57 PM, Yang Shi wrote: >> >> Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP >> in prologue in order to get the correct stack backtrace. >> >> However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to >> change during function call so it may cause the BPF prog stack base address >> change too. >> >> Use x25 to replace FP as BPF stack base register (fp). Since x25 is callee >> saved register, so it will keep intact during function call. >> It is initialized in BPF prog prologue when BPF prog is started to run >> everytime. When BPF prog exits, it could be just tossed. >> >> So, the BPF stack layout looks like: >> >> high >> original A64_SP => 0:+-----+ BPF prologue >> | | FP/LR and callee saved registers >> BPF fp register => -64:+-----+ >> | | >> | ... | BPF prog stack >> | | >> | | >> current A64_SP/FP => +-----+ >> | | >> | ... | Function call stack >> | | >> +-----+ >> low >> > > Yang, for stack unwinding to work, shouldn't it be something like the following? Yes, thanks for catching this. v3 will be post soon. Yang > > | LR | > A64_FP => | FP | > | .. | > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/