MIME-Version: 1.0
In-Reply-To: <1447444387-23525-2-git-send-email-jacob.jun.pan@linux.intel.com>
References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1447444387-23525-2-git-send-email-jacob.jun.pan@linux.intel.com>
Date: Fri, 13 Nov 2015 12:11:01 -0800
Message-ID: <CALAqxLXDhe2G-7vomdMtoM=sLCavaywFZ=e5tBHa4y8=s137fg@mail.gmail.com>
Subject: Re: [PATCH 1/4] ktime: add a roundup function
From: John Stultz <john.stultz@linaro.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1622
Lines: 50

On Fri, Nov 13, 2015 at 11:53 AM, Jacob Pan
<jacob.jun.pan@linux.intel.com> wrote:
> ktime roundup function can be used to keep timer aligned and
> prevent drift for recurring timeouts.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  include/linux/ktime.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/include/linux/ktime.h b/include/linux/ktime.h
> index 2b6a204..2e293fa 100644
> --- a/include/linux/ktime.h
> +++ b/include/linux/ktime.h
> @@ -233,6 +233,16 @@ static inline ktime_t ktime_sub_us(const ktime_t kt, const u64 usec)
>
>  extern ktime_t ktime_add_safe(const ktime_t lhs, const ktime_t rhs);
>
> +static inline ktime_t ktime_roundup(ktime_t x, ktime_t y)
> +{
> +       u64 temp_tv64;
> +
> +       temp_tv64 = x.tv64 + y.tv64 - 1;
> +       temp_tv64 = div64_u64(temp_tv64, y.tv64);
> +       x.tv64 = temp_tv64 * y.tv64;
> +
> +       return x;
> +}

Could you add a comment as to what the function does, and use some
better variable names here to make it more immediately obvious what is
being done here?

Something like:
/**
 * ktime_roundup - Rounds value up to interval chunk
 * @ value: Value to be rounded up
 * @ interval: interval size to round up to
 *
 * Rounds a value up to the next higher multiple of an interval size
 */
static inline ktime ktime_roundup(ktime_t value, ktime_t interval)

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/