Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751037AbbKNGnx (ORCPT ); Sat, 14 Nov 2015 01:43:53 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34337 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbbKNGnw (ORCPT ); Sat, 14 Nov 2015 01:43:52 -0500 Date: Sat, 14 Nov 2015 12:13:44 +0530 From: Sudip Mukherjee To: Nizam Haider Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nizam Haider Subject: Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement Message-ID: <20151114064344.GB3685@sudip-pc> References: <1447428837-24098-1-git-send-email-nizamhaider786@gmail.com> <1447428837-24098-4-git-send-email-nizamhaider786@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447428837-24098-4-git-send-email-nizamhaider786@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 50 On Fri, Nov 13, 2015 at 09:03:56PM +0530, Nizam Haider wrote: > Fix Checlpatch warning > HECK: braces {} should be used on all arms of this statement > > Signed-off-by: Nizam Haider > --- > drivers/staging/dgnc/dgnc_neo.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c > index e980150..99b230f 100644 > --- a/drivers/staging/dgnc/dgnc_neo.c > +++ b/drivers/staging/dgnc/dgnc_neo.c > @@ -1108,9 +1108,10 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch) > * On the other hand, if the UART IS in FIFO mode, then ask > * the UART to give us an approximation of data it has RX'ed. > */ > - if (!(ch->ch_flags & CH_FIFO_ENABLED)) > + if (!(ch->ch_flags & CH_FIFO_ENABLED)) { > total = 0; > - else { > + } > + else { This should be: diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index e980150..67e2667 100644 --- a/drivers/staging/dgnc/dgnc_neo.c +++ b/drivers/staging/dgnc/dgnc_neo.c @@ -1108,9 +1108,9 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch) * On the other hand, if the UART IS in FIFO mode, then ask * the UART to give us an approximation of data it has RX'ed. */ - if (!(ch->ch_flags & CH_FIFO_ENABLED)) + if (!(ch->ch_flags & CH_FIFO_ENABLED)) { total = 0; - else { + } else { total = readb(&ch->ch_neo_uart->rfifo); /* regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/