Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751112AbbKNHFe (ORCPT ); Sat, 14 Nov 2015 02:05:34 -0500 Received: from verein.lst.de ([213.95.11.211]:45191 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbbKNHFd (ORCPT ); Sat, 14 Nov 2015 02:05:33 -0500 Date: Sat, 14 Nov 2015 08:05:31 +0100 From: Christoph Hellwig To: Steve Wise Cc: Christoph Hellwig , linux-rdma@vger.kernel.org, sagig@dev.mellanox.co.il, bart.vanassche@sandisk.com, axboe@fb.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] IB: add a helper to safely drain a QP Message-ID: <20151114070531.GC27738@lst.de> References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-4-git-send-email-hch@lst.de> <56460CC4.3030001@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56460CC4.3030001@opengridcomputing.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 19 On Fri, Nov 13, 2015 at 10:16:04AM -0600, Steve Wise wrote: > So how can we do this for iwarp? It seems like all that might be needed is > to modify the QP state to idle, retrying until it succeeds: > > If the QP is transitioning to the Error state, or has not yet > finished flushing the Work Queues, a Modify QP request to transition > to the IDLE state MUST fail with an Immediate Error. If none of the > prior conditions are true, a Modify QP to the Idle state MUST take > the QP to the Idle state. No other state transitions out of Error > are supported. Any attempt to transition the QP to a state other > than Idle MUST result in an Immediate Error. Can you try to write up some code for this? We could then wire it up in the common helper. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/