MIME-Version: 1.0
In-Reply-To: <56439297.8080408@synaptics.com>
References: <1446766950-31213-1-git-send-email-aduggan@synaptics.com>
	<CACRpkdbGw0ygL+HxBP+vj8+Px6-1O80BbAXYcEsE+uwpz1SBLQ@mail.gmail.com>
	<CAN+gG=HGj4uvzCBwpEsot7qmxjeB8VyzDhYOwOYmDRQCogWtkg@mail.gmail.com>
	<56412410.4030900@synaptics.com>
	<20151109232557.GG9155@dtor-ws>
	<56439297.8080408@synaptics.com>
Date: Sat, 14 Nov 2015 12:35:16 +0100
Message-ID: <CACRpkdYrjLHP8zTF7eVTpGtcY9QBnQDzwsTjkEZzEHibUo+ACQ@mail.gmail.com>
Subject: Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support
From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Benjamin Tissoires <benjamin.tissoires@gmail.com>,
        Linux Input <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Christopher Heiny <cheiny@synaptics.com>,
        Stephen Chandler Paul <cpaul@redhat.com>,
        Allie Xiong <axiong@synaptics.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1157
Lines: 24

On Wed, Nov 11, 2015 at 8:10 PM, Andrew Duggan <aduggan@synaptics.com> wrote:

> I don't know of any non touchpad devices which use F30 and I think it's
> unlikely that there would be any. I think it's really meant for controlling
> the buttons and LEDs which are on the touchpad PCB. There probably isn't
> much reason to wire external GPIOs and LEDs to be controlled by our ASIC*.
> If such a device existed then exporting GPIOs with gpio_chip and using
> gpio-keys seems like a reasonable way to do it. I'm just not sure we will
> have devices which need to use that implementation.
>
> * There is the one exception which is the Lenovo systems which have the
> external physical stick buttons are wired to our ASIC, but that is a special
> case and it's events should be forwarded to the stick's input device instead
> of being reported separately using gpio-keys.

We are aligned here.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/