Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbbKOAxj (ORCPT ); Sat, 14 Nov 2015 19:53:39 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34885 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbbKOAxh (ORCPT ); Sat, 14 Nov 2015 19:53:37 -0500 Message-ID: <1447548801.17039.19.camel@decadent.org.uk> Subject: [stable] Failing to send a CLOSE if file is opened WRONLY and server reboots on a 4.x mount From: Ben Hutchings To: Willy Tarreau , "stable@vger.kernel.org" Cc: "linux-kernel@vger.kernel.org" , Trond Myklebust , "Kornievskaia, Olga" Date: Sun, 15 Nov 2015 00:53:21 +0000 In-Reply-To: <20150916053333.GC29588@1wt.eu> References: <20150912225608.380720062@1wt.eu> <4804EB4C-FCAE-49A7-9075-4C63D72F9AA9@netapp.com> <20150915053741.GB29285@1wt.eu> <7E69BA76-E3DF-4389-A8C4-F23C9E1FD5CC@netapp.com> <55D3ECC9-EC69-469F-AD46-EE3818F3D138@netapp.com> <20150916053333.GC29588@1wt.eu> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-sVD0fDoq+vfSjqYo6sYu" X-Mailer: Evolution 3.18.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2543 Lines: 65 --=-sVD0fDoq+vfSjqYo6sYu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-09-16 at 07:33 +0200, Willy Tarreau wrote: > Hi Olga, >=20 > On Tue, Sep 15, 2015 at 02:36:06PM +0000, Kornievskaia, Olga wrote: > >=20 > > Hi Willy, > >=20 > > After checking with the list, I believe the course of action will be to > > correct the patch with the patch below instead of reverting it. >=20 > OK but as far as I can tell, mainline is still not fixed regarding this > issue. I can't introduce in a stable branch a fix which is not yet in > mainline. Thus I'll simply remove the patch from this series and will > merge both patches in a future series once your fix reaches mainline. >=20 > Note that I picked this fix from 3.2 (commit ef8500b18fc4bb) so my > understanding is that this patch needs to be reverted from 3.2 as well > for the time being ? >=20 > Thanks very much for the detailed investigations! The second patch is now in mainline as commit a41cbe86df3afbc82311a1640e20858c0cd7e065, and appears to be needed on all stable branches since they all got the previous incorrect patch. Ben. --=C2=A0 Ben Hutchings Everything should be made as simple as possible, but not simpler. - Albert Einstei= n --=-sVD0fDoq+vfSjqYo6sYu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVkfXgee/yOyVhhEJAQpAYxAAqlIfPmd6Ifc9PkI2jBerOS8BC9dCsHrg UEm9/YbKRoGKkPft5hTPaItY9MfqfOWquwmWLbCWtn++7TyufoHEui6Qb2HMd6E9 2MbO39OGkuRw5S7kJYY+kCU/zrPnDKMJqN67T2ewuC/kAuetCpkXx835SBjOBbpb WbU9nnXssW5hVpcatt1Vt1SUCpitjhpZ2CaNAxKgFjaPfdD0FLWMBn3V13Rbj84G TZM5EM4B2lsdRsEd7Rr0+g+KgZTQXwKeZtSNqRkfLmzfacRaonyM06cLK8sIsUZn OpMli1W/2A+vLSxTRj2OdHVrxd9r8pmr4KRrj27OcSGfT1gnvy9hWfsqmv2g3Apg JqrfSV8XrSgpfzHQirrsGiiX438PLTctfLEc+PTOztxF1Fas7dzQtPwMye5ZycJC rJ+78R2+fSye3dBe+zdQ3ZEF2ThXnVPjN9ScrPZ0G951trnDY8z25KRJtSzQkqie BUvp2/34gHMuooqI3lYZbQhN2ehjVzbHUxv9qX4vmrV2VikNQQiQ1GblJkz05eJi svMLtrIh0gEGQmCqXaiUApg21VRsZydhACRYHpYmAZFTPai6l+IGGBf6NkNZgJUe g/f6iNHr8GC58bunRizlolvlwPOWnhz9Ma0yCTR/gaPeNq7zqS8hS7MpSPPfvOow Mb3Q/+xus8Q= =LJ5C -----END PGP SIGNATURE----- --=-sVD0fDoq+vfSjqYo6sYu-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/