Subject: Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction
To: Christoph Hellwig <hch@lst.de>, <linux-rdma@vger.kernel.org>
References: <1447422410-20891-1-git-send-email-hch@lst.de>
 <1447422410-20891-10-git-send-email-hch@lst.de>
CC: <sagig@dev.mellanox.co.il>, <bart.vanassche@sandisk.com>, <axboe@fb.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Sagi Grimberg <sagig@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Message-ID: <56484E84.6040904@mellanox.com>
Date: Sun, 15 Nov 2015 11:21:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1447422410-20891-10-git-send-email-hch@lst.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2015 09:21:12.7969
 (UTC)
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB357
X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB0595;2:HAapQJL5ApSdMF+cxqXzCktxiZF7qTL5wTDuuz6iLGRS8mZdLIiYCtSMgW4iKSau4JkiEzODpqZKbWD97NH1rKMfKX0C1k0Xlm9znRBi8AinS/tKz1p3mEa7GE1jRNmURXz/sVb88M6YPCY913rlWR37YDoGpZTyF/6KBO70WzQ=;23:t8ETaa71oU4j41gvK6wjk8D7WJhWz/mth5tRvxvykk/s0r666RzNeWUGVa72DlUkyhJeejy1e72aFlTSTmo8QUJbUP14SabGkHR10LIwFEUeO2mGhrdmROHsv9x/uPKN3z8yM3OjqhNOVU0r3XhEoGZePv1MPBqjO6VlPXWwvjzrrbFvJh8kTyfxPOtvP16d
X-OriginatorOrg: Mellanox.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 937
Lines: 23

On 11/13/2015 3:46 PM, Christoph Hellwig wrote:
> From: Sagi Grimberg<sagig@mellanox.com>

Care to sparse some text here to assist a reviewer and future bisections?!

I have asked multiple times to avoid empty change-logs for patches in 
this driver.

>
> Signed-off-by: Sagi Grimberg<sagig@mellanox.com>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
>   drivers/infiniband/ulp/iser/iscsi_iser.h     |  68 ++++---
>   drivers/infiniband/ulp/iser/iser_initiator.c | 142 ++++++++++-----
>   drivers/infiniband/ulp/iser/iser_memory.c    |  21 ++-
>   drivers/infiniband/ulp/iser/iser_verbs.c     | 258 ++++++---------------------
>   4 files changed, 209 insertions(+), 280 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/