Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752678AbbKOKym (ORCPT ); Sun, 15 Nov 2015 05:54:42 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:21459 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbbKOKyj convert rfc822-to-8bit (ORCPT ); Sun, 15 Nov 2015 05:54:39 -0500 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat/m8Ttpw== X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2 6/8] drivers:input:ads7846(+tsc2046): recognise old binding for coordinate flipping From: "H. Nikolaus Schaller" In-Reply-To: Date: Sun, 15 Nov 2015 11:54:20 +0100 Cc: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , =?iso-8859-1?Q?Beno=EEt_Cousson?= , Tony Lindgren , Russell King , Dmitry Torokhov , Hans Verkuil , Mauro Carvalho Chehab , Sebastian Reichel , Haibo Chen , Andrey Gelman , Igor Grinberg , Aaron Sierra , Krzysztof Kozlowski , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap , List for communicating with real GTA04 owners , "linux-input@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <7F9F737C-A183-4D23-AFAE-90F4ADE8D1E3@goldelico.com> References: To: Rob Herring X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2372 Lines: 55 Am 15.11.2015 um 03:19 schrieb Rob Herring : > On Fri, Nov 13, 2015 at 2:35 PM, H. Nikolaus Schaller wrote: >> By this patch we still recognise the old binding ti,swap-xy in parallel to >> the common binding touchscreen-swapped-x-y. This keeps compatibility >> to older (out-of-tree) device tree binaries. >> >> We do this in a separate patch so that it can be easily reverted in the >> future to retire the old API. A notice is printed to remind developers >> of using old API. >> >> We also fix the bindings name for all in-tree device tree sources in >> a separate patch. > > This one and patch 5 should be combined, so the series is bisectable. Ok. We will loose the easy "revert single patch" option, but you are right that it is simpler if combined. I will add a comment to source code that ti,swap-xy is deprecated and should be removed in the future. > > Rob > >> >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/input/touchscreen/ads7846.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c >> index 4525f00..b9896fd 100644 >> --- a/drivers/input/touchscreen/ads7846.c >> +++ b/drivers/input/touchscreen/ads7846.c >> @@ -1259,7 +1259,11 @@ static const struct ads7846_platform_data *ads7846_probe_dt(struct device *dev) >> of_property_read_u16(node, "ti,vref-mv", &pdata->vref_mv); >> pdata->keep_vref_on = of_property_read_bool(node, "ti,keep-vref-on"); >> >> - pdata->swap_xy = of_property_read_bool(node, "touchscreen-swapped-x-y"); >> + pdata->swap_xy = of_property_read_bool(node, "ti,swap-xy"); >> + if (pdata->swap_xy) >> + dev_notice(dev, "please update device tree to use touchscreen-swapped-x-y"); >> + pdata->swap_xy |= of_property_read_bool(node, >> + "touchscreen-swapped-x-y"); >> >> of_property_read_u16(node, "ti,settle-delay-usec", >> &pdata->settle_delay_usecs); >> -- >> 2.5.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/