Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbbKOR7J (ORCPT ); Sun, 15 Nov 2015 12:59:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:51387 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752457AbbKOR7H (ORCPT ); Sun, 15 Nov 2015 12:59:07 -0500 Date: Sun, 15 Nov 2015 12:59:05 -0500 (EST) Message-Id: <20151115.125905.63907005203700143.davem@davemloft.net> To: andy.shevchenko@gmail.com Cc: linux@rainbow-software.org, netdev@vger.kernel.org, romieu@fr.zoreil.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards From: David Miller In-Reply-To: References: <1447538738-28605-1-git-send-email-linux@rainbow-software.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 15 Nov 2015 09:59:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 34 From: Andy Shevchenko Date: Sun, 15 Nov 2015 04:30:25 +0200 > On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary >> @@ -433,9 +474,10 @@ rio_open (struct net_device *dev) >> >> alloc_list (dev); >> >> - /* Get station address */ >> - for (i = 0; i < 6; i++) >> - dw8(StationAddr0 + i, dev->dev_addr[i]); >> + /* Set station address */ >> + for (i = 0; i < 3; i++) >> + dw16(StationAddr0 + 2 * i, >> + cpu_to_le16(((u16 *)dev->dev_addr)[i])); > > Is it specific requirement for new HW? If not, may be another patch > with micro optimizations. I absolutely agree, this definitely should not just be blindly copied over from the other driver. And if it is a requirement: 1) It must be documented as per why, both in a comment above the loop and in the commit log message. 2) It must therefore be tested on dl2k chips that worked with the dl2k driver beforehand to prove that it doesn't break them. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/