Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752858AbbKPDtB (ORCPT ); Sun, 15 Nov 2015 22:49:01 -0500 Received: from mga01.intel.com ([192.55.52.88]:18343 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752808AbbKPDsg (ORCPT ); Sun, 15 Nov 2015 22:48:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,300,1444719600"; d="scan'208";a="839357767" Date: Mon, 16 Nov 2015 09:22:20 +0530 From: Vinod Koul To: Arnd Bergmann Cc: dmaengine@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma: at_hdmac: use %pad format string for dma_addr_t Message-ID: <20151116035219.GB25173@localhost> References: <3938068.0vDFThTK2h@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3938068.0vDFThTK2h@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 22 On Thu, Nov 12, 2015 at 03:18:22PM +0100, Arnd Bergmann wrote: > dma_addr_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as > gcc correctly warns: > > drivers/dma/at_hdmac.c: In function 'atc_prep_dma_interleaved': > drivers/dma/at_hdmac.c:731:28: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=] > > This changes the format strings to use the special "%pad" format > string that prints a dma_addr_t, and changes the arguments so we > pass the address by reference as required. > Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/