Message-ID: <1447647718.12214.10.camel@Lunix2.home>
Subject: Re: [4.4 regression] 46a7fd8a : pcnet32: use pci_set_dma_mask
 insted of pci_dma_supported
From: Don Fry <pcnet32@frontier.com>
To: Christoph Hellwig <hch@lst.de>
Cc: =?UTF-8?Q?=ED=97=88=EC=A2=85=EB=A7=8C?= <jongman.heo@samsung.com>,
        linux-kernel@vger.kernel.org
Date: Sun, 15 Nov 2015 20:21:58 -0800
In-Reply-To: <20151111115822.GA21200@lst.de>
References: <651688554.823561447231840264.JavaMail.weblogic@ep2mlwas04d>
	 <20151111115822.GA21200@lst.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1275
Lines: 34

On Wed, 2015-11-11 at 12:58 +0100, Christoph Hellwig wrote:
> Can you try the patch below?

Acked-by: Don Fry <pcnet32@frontier.com>
-- 
Since pci_set_dma_mask() returns the opposite of pci_dma_supported(),
this fix is required for proper operation.  The original patch in
October was faulty.
> 
> diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
> index e2afabf..7ccebae 100644
> --- a/drivers/net/ethernet/amd/pcnet32.c
> +++ b/drivers/net/ethernet/amd/pcnet32.c
> @@ -1500,10 +1500,11 @@ pcnet32_probe_pci(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		return -ENODEV;
>  	}
>  
> -	if (!pci_set_dma_mask(pdev, PCNET32_DMA_MASK)) {
> +	err = pci_set_dma_mask(pdev, PCNET32_DMA_MASK);
> +	if (err) {
>  		if (pcnet32_debug & NETIF_MSG_PROBE)
>  			pr_err("architecture does not support 32bit PCI busmaster DMA\n");
> -		return -ENODEV;
> +		return err;
>  	}
>  	if (!request_region(ioaddr, PCNET32_TOTAL_SIZE, "pcnet32_probe_pci")) {
>  		if (pcnet32_debug & NETIF_MSG_PROBE)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/