Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752150AbbKPIEJ (ORCPT ); Mon, 16 Nov 2015 03:04:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:38966 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751164AbbKPIEF (ORCPT ); Mon, 16 Nov 2015 03:04:05 -0500 Date: Mon, 16 Nov 2015 09:04:02 +0100 Message-ID: From: Takashi Iwai To: "Clemens Ladisch" Cc: , "Cheah Kok Cheong" , Subject: Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp() In-Reply-To: <56488E94.1030609@ladisch.de> References: <1447536690-25173-1-git-send-email-thrust73@gmail.com> <56488E94.1030609@ladisch.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1886 Lines: 61 On Sun, 15 Nov 2015 14:54:28 +0100, Clemens Ladisch wrote: > > Cheah Kok Cheong wrote: > > Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro") > > > > And commit 29cc88979a88 ("USB: use usb_endpoint_maxp() > > instead of le16_to_cpu()") > > These sentences no verb. > > > Patched against > > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > This does not belong into the commit message. > > > Signed-off-by: Cheah Kok Cheong > > Otherwise: > Acked-by: Clemens Ladisch Applied now with some manual fixes. thanks, Takashi > > > --- > > sound/usb/misc/ua101.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c > > index 9581089..c19a5dd 100644 > > --- a/sound/usb/misc/ua101.c > > +++ b/sound/usb/misc/ua101.c > > @@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua) > > return -ENXIO; > > } > > ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd)); > > - ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize); > > + ua->capture.max_packet_bytes = usb_endpoint_maxp(epd); > > > > epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc; > > if (!usb_endpoint_is_isoc_out(epd)) { > > @@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua) > > return -ENXIO; > > } > > ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd)); > > - ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize); > > + ua->playback.max_packet_bytes = usb_endpoint_maxp(epd); > > return 0; > > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/