Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbbKPJn1 (ORCPT ); Mon, 16 Nov 2015 04:43:27 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:13001 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628AbbKPJnW (ORCPT ); Mon, 16 Nov 2015 04:43:22 -0500 X-IronPort-AV: E=Sophos;i="5.20,301,1444694400"; d="scan'208";a="318310640" Message-ID: <1447666977.15629.9.camel@citrix.com> Subject: Re: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 From: Ian Campbell To: Stefano Stabellini , Julien Grall CC: , , Date: Mon, 16 Nov 2015 09:42:57 +0000 In-Reply-To: References: <1447349448-22610-2-git-send-email-stefano.stabellini@eu.citrix.com> <5645E868.30706@citrix.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 20 On Fri, 2015-11-13 at 18:10 +0000, Stefano Stabellini wrote: > > I agree with your point (I thought about it myself) but the current > assembly scheme for hypercalls doesn't work well with that. I would have > to introduce, and maintain going forward, two special hypercall > implementations in assembly, one for arm and another for arm64, just to > set interface_version. I don't think it is worth it; I prefer to have to > maintain the explicit interface_version setting at the call sites (that > today is just one). You could give the bare assembly stub a different name (append _core or _raw or something) and make HYPERVISOR_platform_op a C wrapper for it which DTRT. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/