Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbbKPKFw (ORCPT ); Mon, 16 Nov 2015 05:05:52 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34455 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751238AbbKPKFt (ORCPT ); Mon, 16 Nov 2015 05:05:49 -0500 Date: Mon, 16 Nov 2015 02:05:46 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yaowei Bai cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool In-Reply-To: <1447656686-4851-7-git-send-email-baiyaowei@cmss.chinamobile.com> Message-ID: References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-7-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 29 On Mon, 16 Nov 2015, Yaowei Bai wrote: > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 6523109..1da03f5 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -375,12 +375,9 @@ static inline enum zone_type gfp_zone(gfp_t flags) > * virtual kernel addresses to the allocated page(s). > */ > > -static inline int gfp_zonelist(gfp_t flags) > +static inline bool gfp_zonelist(gfp_t flags) > { > - if (IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE)) > - return 1; > - > - return 0; > + return IS_ENABLED(CONFIG_NUMA) && unlikely(flags & __GFP_THISNODE); > } > > /* This function is used to index into a pgdat's node_zonelists[] array, bool makes no sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/