Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbbKPKKQ (ORCPT ); Mon, 16 Nov 2015 05:10:16 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34378 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbKPKKM (ORCPT ); Mon, 16 Nov 2015 05:10:12 -0500 Date: Mon, 16 Nov 2015 02:10:10 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yaowei Bai cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean In-Reply-To: <1447656686-4851-5-git-send-email-baiyaowei@cmss.chinamobile.com> Message-ID: References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-5-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 36 On Mon, 16 Nov 2015, Yaowei Bai wrote: > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index cf55945..af73135 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -8,8 +8,8 @@ > * page_is_file_cache - should the page be on a file LRU or anon LRU? > * @page: the page to test > * > - * Returns 1 if @page is page cache page backed by a regular filesystem, > - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed. > + * Returns true if @page is page cache page backed by a regular filesystem, > + * or false if @page is anonymous, tmpfs or otherwise ram or swap backed. > * Used by functions that manipulate the LRU lists, to sort a page > * onto the right LRU list. > * > @@ -17,7 +17,7 @@ > * needs to survive until the page is last deleted from the LRU, which > * could be as far down as __page_cache_release. > */ > -static inline int page_is_file_cache(struct page *page) > +static inline bool page_is_file_cache(struct page *page) > { > return !PageSwapBacked(page); > } Since page_is_file_cache() is often used to determine which zlc to increment or decrement (usage such as NR_ISOLATED_ANON + page_is_file_cache(page)), I don't think this style is helpful. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/