Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbbKPLVy (ORCPT ); Mon, 16 Nov 2015 06:21:54 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:33420 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbKPLVx (ORCPT ); Mon, 16 Nov 2015 06:21:53 -0500 Message-ID: <5649BC4E.7000105@bjorling.me> Date: Mon, 16 Nov 2015 12:21:50 +0100 From: =?UTF-8?B?TWF0aWFzIEJqw7hybGluZw==?= Organization: Paletta User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thiago Farina CC: linux-block@vger.kernel.org, linux list , axboe@fb.com, geert@linux-m68k.org Subject: Re: [PATCH] lightnvm: change max_phys_sect to ushort References: <1447353300-26027-1-git-send-email-m@bjorling.me> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 39 On 11/16/2015 12:18 PM, Thiago Farina wrote: > On Thu, Nov 12, 2015 at 4:35 PM, Matias Bjørling wrote: >> The max_phys_sect variable is defined as a char. We do a boundary check >> to maximally allow 256 physical page descriptors per command. As we are >> not indexing from zero. This expression is always in false. Bump the >> max_phys_sect to an unsigned short to support the range check. >> > You might have to change the commit message to match the code change. > s/unsigned short/unsigned int. RIght? You're right. It has been fixed. > >> Signed-off-by: Matias Bjørling >> Reported-by: Geert Uytterhoeven >> --- >> include/linux/lightnvm.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h >> index 69c9057..4b1cd3d 100644 >> --- a/include/linux/lightnvm.h >> +++ b/include/linux/lightnvm.h >> @@ -220,7 +220,7 @@ struct nvm_dev_ops { >> nvm_dev_dma_alloc_fn *dev_dma_alloc; >> nvm_dev_dma_free_fn *dev_dma_free; >> >> - uint8_t max_phys_sect; >> + unsigned int max_phys_sect; >> }; >> >> struct nvm_lun { > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/