Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbbKPLlv (ORCPT ); Mon, 16 Nov 2015 06:41:51 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:58487 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbbKPLlt (ORCPT ); Mon, 16 Nov 2015 06:41:49 -0500 From: Arnd Bergmann To: Joseph Myers Cc: Chris Metcalf , linux-arm-kernel@lists.infradead.org, bamvor.zhangjian@huawei.com, Andrew Pinski , "Kapoor, Prasun" , Andreas Schwab , Nathan Lynch , LKML , Alexander Graf , Alexey Klimov , broonie@kernel.org, Yury Norov , Andrew Pinski , David Daney , Catalin Marinas , Jan Dakinevich , Philipp Tomsich , Andrey Konovalov , christoph.muellner@theobroma-systems.com, Mike Frysinger , Paul Eggert , Rich Felker Subject: Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Mon, 16 Nov 2015 12:40:35 +0100 Message-ID: <4389139.prTLIyjV9Z@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1446507046-24604-1-git-send-email-ynorov@caviumnetworks.com> <4814795.z9jdqoW8IP@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BSYuuagIUuoqxU1Y+ew5gg+o5giqaFoQyCTOUohDMT3+a9USdt4 1Yy2+XPACvfthcQWg6mVDjxJ6oHSKNDNr5TFnEbNNVCFOCBTXXj9CbX4GxZXrBmV2o2LNbc vXj3yPMQvSE1ohDhLd39bn0YJuLOYJ7gWRboYRTR2hjggHh3zbHgOyORfWWlqjtfNPraUg6 ywyYb3eoGllWc7gEms4/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:9RFCFt5fe8E=:FnEEMnAyzwqkGx1lNsGDBs vLixLRcvzP6dwELYkiL8Z55vcaXi9jQMSO1UPmepDt9oDAlcaiX0KEi8hAwIdvH89l5e4u6tT F9adtx5W1QoAsLL+SSldcHH6bfldltMr5iGSNMfq5pTkz1Lohk5KIrACIarvxYzclp4EJD/yS 1yocSTgqN/uFi7ntrwqEFcDeVYtCbYQNiYUlvsmlpwPsfS/9VJ7AnHsOCwNHQyw8sFKBLRucF 7CQhpTDYsE/kQDCOeg/SMP2ep/FD6YimWPTll6zLxu6zJXLj3lMJ7TmTBoSaPDhAzYmNMGcgU fWXTYt9t3WIOcqqzRd8klFgqzt0+VnP1afeAw8zU6qsAh7yzRTYNCSe6ZHM9DD110Ut0NKOMK 2IZN/kAc6syAAvMZ5Pl69bSTfmfZv0OFRWu4DJ5Im6S45/uPeBGducWCmpfadGcodW8sqIgSX Tupu4HNF8ZjWaUduBiDIuNlM6N8XJNPlzMktINNfIUyNXy5v5R/Jeq9WAK3OGNiUAbByZaIEK xOaoZsta1ExnGDTjqxz6hpI5ThONjox6gztCAdMz7YgQJ2EKKCQGKW3sptB4t/NfKLelsGRcH 3j+a4NKV8OCs/Non/lYfs7b/4pElt2XtJLIZcVFLYMuRqvLiVSdjr/m2AIjkdXaEtNWL0gNaa NDUWqleOl8FIzcDfN6PVAgALxSbPUkAlmzL4UK8XHBZGsExaX56/8PXi52YSm+LFn9R3SKB/V A1aAi8J1SHWEKMT4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2630 Lines: 49 On Monday 16 November 2015 11:12:08 Joseph Myers wrote: > On Mon, 16 Nov 2015, Arnd Bergmann wrote: > > > Let's not get into the tv_nsec discussion today, that is not thankfully > > not relevant for arm64 any more at this point. The system call ABI for > > arm64/ilp32 is now the same as for any other 32-bit architecture using > > the generic ABI, the question we're trying to solve here is only whether it > > is ok for new 32-bit glibc ports to only offer a 64-bit off_t as the kernel > > currently does (using __kernel_loff_t) or if we still need to support the > > _FILE_OFFSET_BITS=32 case. > > > > If I got you right, we can use 64-bit off_t now, so we just need someone > > to figure out how to make that the default in glibc for new architectures > > while keeping the existing 32-bit architectures unchanged. > > It would be an entirely new combination. Presumably such a port would > want the "function X is an alias of function Y" aspects of wordsize-64 > directories (where that relates to off_t, struct stat etc. as opposed to > long and long long), and the "registers are 64-bit so 64-bit operations > are efficient" aspects, but not all the "64-bit syscall interface" > aspects, so someone would need to review wordsize-64 sysdeps files and > figure out what is or is not relevant to this port. There are two separate aspects here: a) leave out the support for all __off_t based syscalls (__ftruncate, __lseek, __lxstat, __pread, __preadv, __pwrite, __pwritev, __truncate, __xstat) as they are no longer needed, and change the handling of _FILE_OFFSET_BITS so that we default to 64 and error out for anything else. This needs to be done for all new 32-bit architectures if you think we should use a 64-bit off_t from now on, it's not arm64 specific. b) For an arbitrary subset of these, introduce optimized versions that are architecture specific and take advantage of the fact that we can pass 64-bit register arguments on arm64-ilp32. This is only needed because we diverge from the generic ABI in order to avoid the silliness of splitting up a 64-bit argument and then re-assembling it in the kernel. This should not be needed in the generic ABI and could just live in sysdeps/unix/sysv/linux/aarch64/wordsize-32, just like we have special handling for each one in the arm64 in the kernel code for them. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/