Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbbKPMSX (ORCPT ); Mon, 16 Nov 2015 07:18:23 -0500 Received: from icp-osb-irony-out4.external.iinet.net.au ([203.59.1.220]:44247 "EHLO icp-osb-irony-out4.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbbKPMSW (ORCPT ); Mon, 16 Nov 2015 07:18:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq0BABzISVY6B+fy/2dsb2JhbAANUYR9q1IBAQEGkGCEDIYQAoIDAQEBAQEBhUABAQQ4QAEQCw0LCRYPCQMCAQIBRQYBDAYCAQGxUJB1AQEBAQEBAQECAQEBAQEBHYYNhUWJOQEElkiPAodZhXiJJ4NygnQdFoFSYIVLAQEB X-IronPort-AV: E=Sophos;i="5.20,302,1444665600"; d="scan'208";a="27211249" Subject: Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn To: Geert Uytterhoeven , Sam Creasey , linux-m68k@vger.kernel.org References: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> <1447585455-19671-5-git-send-email-geert@linux-m68k.org> Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org From: Greg Ungerer Message-ID: <5649C987.3050600@uclinux.org> Date: Mon, 16 Nov 2015 22:18:15 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447585455-19671-5-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 50 Hi Geert, On 15/11/15 21:04, Geert Uytterhoeven wrote: > If max_pfn is not initialized, the block layer may use wrong DMA masks. > > Replace open-coded shifts by PFN_DOWN() while we're at it. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. > --- > arch/m68k/kernel/setup_no.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c > index 88c27d94a7214c95..29b44e69f0f47375 100644 > --- a/arch/m68k/kernel/setup_no.c > +++ b/arch/m68k/kernel/setup_no.c > @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) > * Give all the memory to the bootmap allocator, tell it to put the > * boot mem_map at the start of memory. > */ > + min_low_pfn = PFN_DOWN(memory_start); > + max_pfn = max_low_pfn = PFN_DOWN(memory_end); > + > bootmap_size = init_bootmem_node( > NODE_DATA(0), > - memory_start >> PAGE_SHIFT, /* map goes here */ > - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire */ > - memory_end >> PAGE_SHIFT); > + min_low_pfn, /* map goes here */ > + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */ > + max_pfn); > /* > * Free the usable memory, we have to make sure we do not free > * the bootmem bitmap so we then reserve it after freeing it :-) Should this be changed to use init_bootmem() as per your changes in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and {min,max}_low_pfn")? For the same reason? Regards Greg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/