Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbbKPMjb (ORCPT ); Mon, 16 Nov 2015 07:39:31 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34923 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbbKPMja (ORCPT ); Mon, 16 Nov 2015 07:39:30 -0500 Date: Mon, 16 Nov 2015 13:39:27 +0100 From: Michal Hocko To: Yaowei Bai Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean Message-ID: <20151116123927.GB14116@dhcp22.suse.cz> References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-2-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447656686-4851-2-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2045 Lines: 69 On Mon 16-11-15 14:51:20, Yaowei Bai wrote: > This patch makes is_file_shm_hugepages return bool to improve > readability due to this particular function only using either > one or zero as its return value. yes it makes sense here. > No functional change. > > Signed-off-by: Yaowei Bai Acked-by: Michal Hocko > --- > include/linux/shm.h | 6 +++--- > ipc/shm.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/shm.h b/include/linux/shm.h > index 6fb8016..04e8818 100644 > --- a/include/linux/shm.h > +++ b/include/linux/shm.h > @@ -52,7 +52,7 @@ struct sysv_shm { > > long do_shmat(int shmid, char __user *shmaddr, int shmflg, unsigned long *addr, > unsigned long shmlba); > -int is_file_shm_hugepages(struct file *file); > +bool is_file_shm_hugepages(struct file *file); > void exit_shm(struct task_struct *task); > #define shm_init_task(task) INIT_LIST_HEAD(&(task)->sysvshm.shm_clist) > #else > @@ -66,9 +66,9 @@ static inline long do_shmat(int shmid, char __user *shmaddr, > { > return -ENOSYS; > } > -static inline int is_file_shm_hugepages(struct file *file) > +static inline bool is_file_shm_hugepages(struct file *file) > { > - return 0; > + return false; > } > static inline void exit_shm(struct task_struct *task) > { > diff --git a/ipc/shm.c b/ipc/shm.c > index 4178727..ed3027d 100644 > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -459,7 +459,7 @@ static const struct file_operations shm_file_operations_huge = { > .fallocate = shm_fallocate, > }; > > -int is_file_shm_hugepages(struct file *file) > +bool is_file_shm_hugepages(struct file *file) > { > return file->f_op == &shm_file_operations_huge; > } > -- > 1.9.1 > > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/