Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbbKPMly (ORCPT ); Mon, 16 Nov 2015 07:41:54 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33576 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875AbbKPMlx (ORCPT ); Mon, 16 Nov 2015 07:41:53 -0500 Date: Mon, 16 Nov 2015 13:41:50 +0100 From: Michal Hocko To: Yaowei Bai Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] mm/memblock: memblock_is_memory/reserved can be boolean Message-ID: <20151116124150.GD14116@dhcp22.suse.cz> References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-4-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447656686-4851-4-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2169 Lines: 64 On Mon 16-11-15 14:51:22, Yaowei Bai wrote: > This patch makes memblock_is_memory/reserved return bool to improve > readability due to this particular function only using either > one or zero as its return value. > > No functional change. > > Signed-off-by: Yaowei Bai Acked-by: Michal Hocko > --- > include/linux/memblock.h | 4 ++-- > mm/memblock.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 24daf8f..a25cce94 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -318,9 +318,9 @@ phys_addr_t memblock_mem_size(unsigned long limit_pfn); > phys_addr_t memblock_start_of_DRAM(void); > phys_addr_t memblock_end_of_DRAM(void); > void memblock_enforce_memory_limit(phys_addr_t memory_limit); > -int memblock_is_memory(phys_addr_t addr); > +bool memblock_is_memory(phys_addr_t addr); > int memblock_is_region_memory(phys_addr_t base, phys_addr_t size); > -int memblock_is_reserved(phys_addr_t addr); > +bool memblock_is_reserved(phys_addr_t addr); > bool memblock_is_region_reserved(phys_addr_t base, phys_addr_t size); > > extern void __memblock_dump_all(void); > diff --git a/mm/memblock.c b/mm/memblock.c > index d300f13..1ab7b9e 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1509,12 +1509,12 @@ static int __init_memblock memblock_search(struct memblock_type *type, phys_addr > return -1; > } > > -int __init memblock_is_reserved(phys_addr_t addr) > +bool __init memblock_is_reserved(phys_addr_t addr) > { > return memblock_search(&memblock.reserved, addr) != -1; > } > > -int __init_memblock memblock_is_memory(phys_addr_t addr) > +bool __init_memblock memblock_is_memory(phys_addr_t addr) > { > return memblock_search(&memblock.memory, addr) != -1; > } > -- > 1.9.1 > > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/