Date: Mon, 16 Nov 2015 13:45:01 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com,
        dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com,
        dingel@linux.vnet.ibm.com, hannes@cmpxchg.org,
        hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com,
        joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de,
        mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org,
        rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org,
        tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] mm/mmzone: refactor memmap_valid_within
Message-ID: <20151116124501.GF14116@dhcp22.suse.cz>
References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <1447656686-4851-8-git-send-email-baiyaowei@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1447656686-4851-8-git-send-email-baiyaowei@cmss.chinamobile.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 37

On Mon 16-11-15 14:51:26, Yaowei Bai wrote:
[...]
> @@ -72,16 +72,10 @@ struct zoneref *next_zones_zonelist(struct zoneref *z,
>  }
>  
>  #ifdef CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
> -int memmap_valid_within(unsigned long pfn,
> +bool memmap_valid_within(unsigned long pfn,
>  					struct page *page, struct zone *zone)
>  {
> -	if (page_to_pfn(page) != pfn)
> -		return 0;
> -
> -	if (page_zone(page) != zone)
> -		return 0;
> -
> -	return 1;
> +	return page_to_pfn(page) == pfn && page_zone(page) == zone;

I do not think this is easier to read. Quite contrary

>  }
>  #endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */
>  
> -- 
> 1.9.1
> 
> 

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/