Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbbKPNGA (ORCPT ); Mon, 16 Nov 2015 08:06:00 -0500 Received: from mail-ob0-f194.google.com ([209.85.214.194]:35596 "EHLO mail-ob0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbbKPNF4 (ORCPT ); Mon, 16 Nov 2015 08:05:56 -0500 MIME-Version: 1.0 In-Reply-To: <5649C987.3050600@uclinux.org> References: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> <1447585455-19671-5-git-send-email-geert@linux-m68k.org> <5649C987.3050600@uclinux.org> Date: Mon, 16 Nov 2015 14:05:55 +0100 X-Google-Sender-Auth: C3e4LEMp14zaxLXtVV60bbxni5k Message-ID: Subject: Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn From: Geert Uytterhoeven To: Greg Ungerer Cc: Sam Creasey , linux-m68k , Linux-Arch , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2159 Lines: 53 Hi Greg, On Mon, Nov 16, 2015 at 1:18 PM, Greg Ungerer wrote: >> --- a/arch/m68k/kernel/setup_no.c >> +++ b/arch/m68k/kernel/setup_no.c >> @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) >> * Give all the memory to the bootmap allocator, tell it to put >> the >> * boot mem_map at the start of memory. >> */ >> + min_low_pfn = PFN_DOWN(memory_start); >> + max_pfn = max_low_pfn = PFN_DOWN(memory_end); >> + >> bootmap_size = init_bootmem_node( >> NODE_DATA(0), >> - memory_start >> PAGE_SHIFT, /* map goes here */ >> - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire >> */ >> - memory_end >> PAGE_SHIFT); >> + min_low_pfn, /* map goes here */ >> + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */ >> + max_pfn); >> /* >> * Free the usable memory, we have to make sure we do not free >> * the bootmem bitmap so we then reserve it after freeing it :-) > > Should this be changed to use init_bootmem() as per your changes > in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and > {min,max}_low_pfn")? For the same reason? No. PAGE_OFFSET = PAGE_OFFSET_RAW = CONFIG_RAMBASE. As the comment says, this is zero on coldfire, but not on all m68knommu platforms. Upon closer look, this isn't even true on all Coldfire boards: arch/m68k/configs/m5208evb_defconfig:CONFIG_RAMBASE=0x40000000 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/