Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbbKPNKz (ORCPT ); Mon, 16 Nov 2015 08:10:55 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35934 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbbKPNKw (ORCPT ); Mon, 16 Nov 2015 08:10:52 -0500 Subject: Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate To: Boris Brezillon , Thierry Reding , linux-pwm@vger.kernel.org References: <1447664207-24370-1-git-send-email-boris.brezillon@free-electrons.com> <1447664207-24370-6-git-send-email-boris.brezillon@free-electrons.com> Cc: Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors@lm-sensors.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input@vger.kernel.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Robert Jarzmik , Alexandre Belloni , Julia Lawall , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, k.kozlowski.k@gmail.com From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-ID: <5649D5D0.6080204@samsung.com> Date: Mon, 16 Nov 2015 22:10:40 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447664207-24370-6-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2627 Lines: 85 W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > Doing that will ease adaptation of the PWM framework to support atomic > update. > > Signed-off-by: Boris Brezillon > --- > Patch generated with the following coccinelle script: > > --->8--- > virtual patch > > @@ > struct pwm_device *p; > expression e; > @@ > ( > -(p)->polarity = e; > +pwm_set_polarity((p), e); > | > -(p)->polarity > +pwm_get_polarity((p)) > | > -(p)->period = e; > +pwm_set_period((p), e); > | > -(p)->period > +pwm_get_period((p)) > | > -(p)->duty_cycle = e; > +pwm_set_duty_cycle((p), e); > | > -(p)->duty_cycle > +pwm_get_duty_cycle((p)) > ) > --->8--- > --- > drivers/input/misc/max77693-haptic.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c > index 6d96bff..a038fb3 100644 > --- a/drivers/input/misc/max77693-haptic.c > +++ b/drivers/input/misc/max77693-haptic.c > @@ -70,10 +70,11 @@ struct max77693_haptic { > > static int max77693_haptic_set_duty_cycle(struct max77693_haptic *haptic) > { > - int delta = (haptic->pwm_dev->period + haptic->pwm_duty) / 2; > + int delta = (pwm_get_period((haptic->pwm_dev)) + haptic->pwm_duty) / 2; Double parentheses over argument are not needed so just: pwm_get_period(haptic->pwm_dev) + ... Beside that patch looks good, so with removing parentheses here and below: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > int error; > > - error = pwm_config(haptic->pwm_dev, delta, haptic->pwm_dev->period); > + error = pwm_config(haptic->pwm_dev, delta, > + pwm_get_period((haptic->pwm_dev))); > if (error) { > dev_err(haptic->dev, "failed to configure pwm: %d\n", error); > return error; > @@ -245,7 +246,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data, > * The formula to convert magnitude to pwm_duty as follows: > * - pwm_duty = (magnitude * pwm_period) / MAX_MAGNITUDE(0xFFFF) > */ > - period_mag_multi = (u64)haptic->pwm_dev->period * haptic->magnitude; > + period_mag_multi = (u64)pwm_get_period((haptic->pwm_dev)) * haptic->magnitude; > haptic->pwm_duty = (unsigned int)(period_mag_multi >> > MAX_MAGNITUDE_SHIFT); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/