Date: Mon, 16 Nov 2015 09:22:42 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>, Ingo Molnar <mingo@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Rik van Riel <riel@redhat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        jmarchan@redhat.com, mgorman@techsingularity.net,
        willy@linux.intel.com, linux-kernel <linux-kernel@vger.kernel.org>,
        linux-mm@kvack.org
Subject: Re: [PATCH V4] mm: fix kernel crash in khugepaged thread
Message-ID: <20151116092242.26474f89@gandalf.local.home>
In-Reply-To: <2F74FF6B-66DC-4BF9-972A-C2F5FFFA979F@gmail.com>
References: <1447316462-19645-1-git-send-email-yalin.wang2010@gmail.com>
	<20151112092923.19ee53dd@gandalf.local.home>
	<5645BFAA.1070004@suse.cz>
	<D7E480F5-D879-4016-B530-5A4D7CB05675@gmail.com>
	<20151113090115.1ad4235b@gandalf.local.home>
	<2F74FF6B-66DC-4BF9-972A-C2F5FFFA979F@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1862
Lines: 50

On Mon, 16 Nov 2015 09:35:53 +0800
yalin wang <yalin.wang2010@gmail.com> wrote:

> > On Nov 13, 2015, at 22:01, Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > On Fri, 13 Nov 2015 19:54:11 +0800
> > yalin wang <yalin.wang2010@gmail.com> wrote:
> >   
> >>>>> 	TP_fast_assign(
> >>>>> 		__entry->mm = mm;
> >>>>> -		__entry->pfn = pfn;
> >>>>> +		__entry->pfn = page_to_pfn(page);    
> >>>> 
> >>>> Instead of the condition, we could have:
> >>>> 
> >>>> 	__entry->pfn = page ? page_to_pfn(page) : -1;    
> >>> 
> >>> I agree. Please do it like this.    
> > 
> > hmm, pfn is defined as an unsigned long, would -1 be the best.
> > Or should it be (-1UL).
> > 
> > Then we could also have:
> > 
> >        TP_printk("mm=%p, scan_pfn=0x%lx%s, writable=%d, referenced=%d, none_or_zero=%d, status=%s, unmapped=%d",
> >                __entry->mm,
> >                __entry->pfn == (-1UL) ? 0 : __entry->pfn,
> > 		__entry->pfn == (-1UL) ? "(null)" : "",
> > 
> > Note the added %s after %lx I have in the print format.
> > 
> > -- Steve  
> it is not easy to print for perf tools in userspace ,
> if you use this format ,
> for user space perf tool, it print the entry by look up the member in entry struct by offset ,
> you print a dynamic string which user space perf tool don’t know how to print this string .

Have you tried it? It should work. If not, I'll fix it. The string
"null" is exported in the trace output file, and perf should have
enough information to know how to handle that. If it fails to parse, I
can easily fix it.

Remember, I'm the author of the parsing of events in userspace.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/