Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbKPPU7 (ORCPT ); Mon, 16 Nov 2015 10:20:59 -0500 Received: from mail.kernel.org ([198.145.29.136]:47335 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbKPPU5 (ORCPT ); Mon, 16 Nov 2015 10:20:57 -0500 Date: Mon, 16 Nov 2015 09:20:51 -0600 From: Rob Herring To: huangdaode Cc: davem@davemloft.net, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, dingtianhong@huawei.com, zhangfei.gao@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com Subject: Re: [PATCH v2 net-next] net: hisilicon: fix binding document of mdio Message-ID: <20151116152051.GA7183@rob-hp-laptop> References: <1447666704-200773-1-git-send-email-huangdaode@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447666704-200773-1-git-send-email-huangdaode@hisilicon.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 55 On Mon, Nov 16, 2015 at 05:38:24PM +0800, huangdaode wrote: > This patch explains the occasion of "hisilcon,mdio" and > "hisilicon,hns-mdio" according to Arnd's comments. > and reformat it according to comments from Rob. > > chang log: > > v2: > 1) reformat the style. > 2) make it more clearity. > > v1: > initial version. > > Signed-off-by: huangdaode > --- > Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > index 9c23fdf..4942d20 100644 > --- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt > @@ -1,7 +1,12 @@ > Hisilicon MDIO bus controller > > Properties: > -- compatible: "hisilicon,mdio","hisilicon,hns-mdio". > +- compatible: can be one of: > + "hisilicon,hns-mdio" > + "hisilicon,mdio" > + "hisilicon,hns-mdio" is recommendly to be used for hip05 and later SOCs, s/recommendly/recommended/ > + while "hisilicon,mdio" is optional for backwards compatibility, only > + support for hip04 Soc. ...compatibility only on hip04 SOC. > - reg: The base address of the MDIO bus controller register bank. > - #address-cells: Must be <1>. > - #size-cells: Must be <0>. MDIO addresses have no size component. > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/