Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbbKPP33 (ORCPT ); Mon, 16 Nov 2015 10:29:29 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:59373 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751646AbbKPP31 (ORCPT ); Mon, 16 Nov 2015 10:29:27 -0500 From: Punit Agrawal To: Viresh Kumar Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, edubezval@gmail.com, dawei.chien@mediatek.com, Sudeep Holla Subject: Re: [PATCH v3 3/3] cpufreq: arm_big_little: Add support to register a cpufreq cooling device References: <1447090163-13700-1-git-send-email-punit.agrawal@arm.com> <1447090163-13700-4-git-send-email-punit.agrawal@arm.com> <20151113045610.GC3576@ubuntu> Date: Mon, 16 Nov 2015 15:29:09 +0000 In-Reply-To: <20151113045610.GC3576@ubuntu> (Viresh Kumar's message of "Fri, 13 Nov 2015 10:26:10 +0530") Message-ID: <9hha8qeq7y2.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2360 Lines: 53 Viresh Kumar writes: > On 09-11-15, 17:29, Punit Agrawal wrote: >> Register passive cooling devices when initialising cpufreq on >> big.LITTLE systems. If the device tree provides a dynamic power >> coefficient for the CPUs then the bound cooling device will support >> the extensions that allow it to be used with all the existing thermal >> governors including the power allocator governor. >> >> A cooling device will be created per individual frequency domain and >> can be bound to thermal zones via the thermal DT bindings. >> >> Signed-off-by: Punit Agrawal >> Acked-by: Viresh Kumar >> Cc: Sudeep Holla >> Cc: Eduardo Valentin >> --- >> drivers/cpufreq/arm_big_little.c | 52 ++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 50 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c >> index f1e42f8..72a2777 100644 >> --- a/drivers/cpufreq/arm_big_little.c >> +++ b/drivers/cpufreq/arm_big_little.c >> @@ -23,6 +23,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -55,6 +56,10 @@ static bool bL_switching_enabled; >> #define ACTUAL_FREQ(cluster, freq) ((cluster == A7_CLUSTER) ? freq << 1 : freq) >> #define VIRT_FREQ(cluster, freq) ((cluster == A7_CLUSTER) ? freq >> 1 : freq) >> >> +struct private_data { >> + struct thermal_cooling_device *cdev; >> +}; > > I think we need to be consistent within the driver, and so this must > be stored in a similar way to what we do for other structures. We have > static arrays for them, please do it that way only OR first change all > of them to be part of a bigger private_data structure. Sure, I'll switch to using static arrays. There seem to be a lot of assumptions that might be easily broken in moving all the data into a single structure. I'll leave that as a later change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/