Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbbKPPzu (ORCPT ); Mon, 16 Nov 2015 10:55:50 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:52609 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbbKPPzp (ORCPT ); Mon, 16 Nov 2015 10:55:45 -0500 Subject: Re: [PATCH v4 05/24] misc: max77693-haptic: use pwm_get_xxx() helpers where appropriate To: Boris Brezillon , Krzysztof Kozlowski References: <1447664207-24370-1-git-send-email-boris.brezillon@free-electrons.com> <1447664207-24370-6-git-send-email-boris.brezillon@free-electrons.com> <5649D5D0.6080204@samsung.com> <20151116145509.3ea50eb0@bbrezillon> Cc: Thierry Reding , linux-pwm@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors@lm-sensors.org, Jean Delvare , Dmitry Torokhov , linux-input@vger.kernel.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Robert Jarzmik , Alexandre Belloni , Julia Lawall , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, k.kozlowski.k@gmail.com From: Guenter Roeck Message-ID: <5649FC75.8020203@roeck-us.net> Date: Mon, 16 Nov 2015 07:55:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151116145509.3ea50eb0@bbrezillon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=0.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3299 Lines: 109 On 11/16/2015 05:55 AM, Boris Brezillon wrote: > Hi Krzysztof, > > On Mon, 16 Nov 2015 22:10:40 +0900 > Krzysztof Kozlowski wrote: > >> W dniu 16.11.2015 o 17:56, Boris Brezillon pisze: >>> Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. >>> Doing that will ease adaptation of the PWM framework to support atomic >>> update. >>> >>> Signed-off-by: Boris Brezillon >>> --- >>> Patch generated with the following coccinelle script: >>> >>> --->8--- >>> virtual patch >>> >>> @@ >>> struct pwm_device *p; >>> expression e; >>> @@ >>> ( >>> -(p)->polarity = e; >>> +pwm_set_polarity((p), e); >>> | >>> -(p)->polarity >>> +pwm_get_polarity((p)) >>> | >>> -(p)->period = e; >>> +pwm_set_period((p), e); >>> | >>> -(p)->period >>> +pwm_get_period((p)) >>> | >>> -(p)->duty_cycle = e; >>> +pwm_set_duty_cycle((p), e); >>> | >>> -(p)->duty_cycle >>> +pwm_get_duty_cycle((p)) >>> ) >>> --->8--- >>> --- >>> drivers/input/misc/max77693-haptic.c | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/input/misc/max77693-haptic.c b/drivers/input/misc/max77693-haptic.c >>> index 6d96bff..a038fb3 100644 >>> --- a/drivers/input/misc/max77693-haptic.c >>> +++ b/drivers/input/misc/max77693-haptic.c >>> @@ -70,10 +70,11 @@ struct max77693_haptic { >>> >>> static int max77693_haptic_set_duty_cycle(struct max77693_haptic *haptic) >>> { >>> - int delta = (haptic->pwm_dev->period + haptic->pwm_duty) / 2; >>> + int delta = (pwm_get_period((haptic->pwm_dev)) + haptic->pwm_duty) / 2; >> >> Double parentheses over argument are not needed so just: >> pwm_get_period(haptic->pwm_dev) + ... > > Actually it was generated with coccinelle, hence I didn't fix existing > coding style issues, but I have no problem fixing them. > There was no existing coding style issue. Your coccinelle script introduces it. You might want to consider updating your script and remove the unnecessary (( )) from it. Guenter > Thanks, > > Boris > >> >> Beside that patch looks good, so with removing parentheses here and below: >> >> Reviewed-by: Krzysztof Kozlowski >> >> Best regards, >> Krzysztof >> >>> int error; >>> >>> - error = pwm_config(haptic->pwm_dev, delta, haptic->pwm_dev->period); >>> + error = pwm_config(haptic->pwm_dev, delta, >>> + pwm_get_period((haptic->pwm_dev))); >>> if (error) { >>> dev_err(haptic->dev, "failed to configure pwm: %d\n", error); >>> return error; >>> @@ -245,7 +246,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data, >>> * The formula to convert magnitude to pwm_duty as follows: >>> * - pwm_duty = (magnitude * pwm_period) / MAX_MAGNITUDE(0xFFFF) >>> */ >>> - period_mag_multi = (u64)haptic->pwm_dev->period * haptic->magnitude; >>> + period_mag_multi = (u64)pwm_get_period((haptic->pwm_dev)) * haptic->magnitude; >>> haptic->pwm_duty = (unsigned int)(period_mag_multi >> >>> MAX_MAGNITUDE_SHIFT); >>> >>> >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/