Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbbKPQLl (ORCPT ); Mon, 16 Nov 2015 11:11:41 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:39792 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbbKPQLj (ORCPT ); Mon, 16 Nov 2015 11:11:39 -0500 From: Felipe Balbi To: Neil Armstrong , Greg Kroah-Hartman , Laurent Pinchart , , Subject: Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver In-Reply-To: <56210FB1.4030507@baylibre.com> References: <56210FB1.4030507@baylibre.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 16 Nov 2015 10:11:32 -0600 Message-ID: <87ziydncuj.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3547 Lines: 95 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Neil Armstrong writes: > Introduces UDC support for the Device-Mode only version of the > Cadence USB2 Controller IP Core. > > Host mode and OTG mode are not implemented by lack of hardware. > Support for Isochronous endpoints is not implemented by lack of time. > > Internal DMA is supported and can be activated by DT property. > > Signed-off-by: Neil Armstrong looks like there are a few checkpatch warnings to be fixed: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #89:=20 new file mode 100644 WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? #233: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:44: + * - EP Bulk and Interrupt tranfer WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rath= er than BUG() or BUG_ON() #968: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:779: + BUG(); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rath= er than BUG() or BUG_ON() #1492: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1303: + BUG(); WARNING: DT compatible string "cdns,usbhs-udc" appears un-documented -- che= ck workspace/linux/Documentation/devicetree/bindings/ #1882: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1693: + { .compatible =3D "cdns,usbhs-udc" }, WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? #2603: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:272: +#define HSUDC_DMA_BUSCTRL_HSIZE_8BIT (0 << 1) /* 8-bit data tranfer */ WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? #2604: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:273: +#define HSUDC_DMA_BUSCTRL_HSIZE_16BIT (1 << 1) /* 16-bit data tranfer */ WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? #2605: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:274: +#define HSUDC_DMA_BUSCTRL_HSIZE_32BIT (2 << 1) /* 32-bit data tranfer */ WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? #2607: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:276: +#define HSUDC_DMA_BUSCTRL_BURST_SINGLE (0 << 4) /* Single tranfer */ total: 0 errors, 9 warnings, 2499 lines checked Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWSgA1AAoJEIaOsuA1yqREK7MP/iQL8hOPuGW3vEy7NQw3h405 NzzQ/W7I4WnXLjbGXqQQqTIXyTfRLTkxfPEOuFCvy77YjV0O0plswc5R6OygjZsj Ei5rIgz8Zu2/TNaJJa3Ev1GZJzeIMWDO59brPkPRBEIvRgVy0x7ThppoUmh9lkCl N19SPNiXBMjN/XHAv8U/8+H1aXZpFkABIAIx4fwWJ+Fpgaxvh99Qo5nYfBvUN9AU G103WkHs45uBKA6PNtWJUnwsEEMv14Ew7bozo7R4N8Uh+31YWabxEAIKhDWoOs1P W5EFzc5PiDYlwuAIWAAC+/4Wcy9Bsj/3NuidMa6cS3lAyKwSCEq5m/pRq2TiABbr fzH+uw3guyFHpvk92tX/OhriidBjOtFPQZtYVG93cvtdLTYchYFH+Df+bxNitg0T t4h32ry4OQM+nF4T7KC/rj8VLQGtnQ+ahPu6Cp7xXzxvOS9utfgNMYGDO6u+nOre Ezsl83dvS4rESzxQhOrhyN4k3D1NjZcJ3rdCQw+uDsOAMj4O/FUmXC+yXX/WRLHc hrTwfFL21WPekdK2r9ZE2E6RsPCjtbxJfADXbyFq7Eig14bmBZt3QDd/W5/DKiUU gPJN4J+E+lC0ldY01YzD55PspBN3IhWh4/4/v7gVMV7o8DfpHFq0Af9QTshe9rLg oNpE+rwjqtU02QC4d7eV =yUyT -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/