Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbbKPQua (ORCPT ); Mon, 16 Nov 2015 11:50:30 -0500 Received: from foss.arm.com ([217.140.101.70]:51198 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752643AbbKPQu0 (ORCPT ); Mon, 16 Nov 2015 11:50:26 -0500 Date: Mon, 16 Nov 2015 16:50:24 +0000 From: Liviu Dudau To: Heiko =?utf-8?Q?St=C3=BCbner?= Cc: Russell King , Mark Yao , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt , linux-rockchip , LAKML , dri-devel , LKML Subject: Re: [PATCH 0/2] Improve drm_of_component_probe() and move rockchip to use it Message-ID: <20151116165024.GB4158@e106497-lin.cambridge.arm.com> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <2290660.pLIRHdxPYF@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2290660.pLIRHdxPYF@diego> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2821 Lines: 66 On Mon, Nov 16, 2015 at 05:07:17PM +0100, Heiko Stübner wrote: > Hi Liviu, > > Am Montag, 16. November 2015, 14:44:51 schrieb Liviu Dudau: > > When I have introduced the drm_of_component_probe() function I have managed > > to break rockchip's DRM driver as the compare_of() function had to match > > both local crtc ports and remote encoder ones. As suggested by Russell > > King, I have now enhanced the drm_of_component_probe() function to take two > > comparison functions, and converted (again) rockchip driver to use it. > > > > I would really like to get some Tested-By this time if possible from IMX, > > Armada and Rockchip developers as I lack hardware to do that myself. > > > > The only thing not implemented from Russell's suggestion list is the > > renaming of the function into drm_kms_component_probe(). > > with these patches applied I loose the display on my rk3288. A bit of dumb > debug-output shows that the compare function does seem to do strange things: > > [ 1.020476] [drm] Initialized drm 1.1.0 20060810 > [ 1.025943] drm_of_component_probe: adding port /vop@ff940000/port > [ 1.032225] drm_of_component_probe: adding port /vop@ff930000/port > [ 1.038421] drm_of_component_probe: adding encoder /hdmi@ff980000 > [ 1.044535] drm_of_component_probe: adding encoder /edp@ff970000 > [ 1.050562] drm_of_component_probe: adding encoder /hdmi@ff980000 > [ 1.056663] drm_of_component_probe: adding encoder /edp@ff970000 > > ---- Columns: dev->parent / dev comparing dev->parent->of_node with np > > [ 1.062683] compare_port: platform/ff980000.hdmi comparing NULL with /vop@ff940000/port > [ 1.071017] compare_port: platform/ff980000.hdmi comparing NULL with /vop@ff940000/port > [ 1.079024] compare_port: platform/ff930000.vop comparing NULL with /vop@ff940000/port > [ 1.087117] compare_port: platform/ff980000.hdmi comparing NULL with /vop@ff940000/port > [ 1.095130] compare_port: platform/ff930000.vop comparing NULL with /vop@ff940000/port > [ 1.103054] compare_port: platform/ff940000.vop comparing NULL with /vop@ff940000/port > [ 1.111553] panel_regulator: supplied by vcc33_sys > > > I need to dig deeper to find out what's happening there, but maybe you > already have some idea in the meantime :-) Did I got the content of the compare_{port,encoder}() functions the wrong way around? Best regards, Liviu > > > Thanks > Heiko > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/