Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753167AbbKPQwM (ORCPT ); Mon, 16 Nov 2015 11:52:12 -0500 Received: from foss.arm.com ([217.140.101.70]:51236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbbKPQwI (ORCPT ); Mon, 16 Nov 2015 11:52:08 -0500 Date: Mon, 16 Nov 2015 16:52:06 +0000 From: Liviu Dudau To: Russell King - ARM Linux Cc: Mark Yao , Heiko Stuebner , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt , linux-rockchip , LAKML , dri-devel , LKML Subject: Re: [PATCH 2/2] drm/rockchip: Convert the probe function to the generic drm_of_component_probe() Message-ID: <20151116165206.GC4158@e106497-lin.cambridge.arm.com> References: <1447685093-26129-1-git-send-email-Liviu.Dudau@arm.com> <1447685093-26129-3-git-send-email-Liviu.Dudau@arm.com> <20151116163016.GO8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151116163016.GO8644@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2248 Lines: 87 On Mon, Nov 16, 2015 at 04:30:16PM +0000, Russell King - ARM Linux wrote: > I've tweaked your patch to make the above (buggy) change a little clearer. > > On Mon, Nov 16, 2015 at 02:44:53PM +0000, Liviu Dudau wrote: > > - for (i = 0;; i++) { > > - port = of_parse_phandle(np, "ports", i); > > - if (!port) > > - break; > > - > > - if (!of_device_is_available(port->parent)) { > > - of_node_put(port); > > - continue; > > - } > > > > - component_match_add(dev, &match, compare_of, port->parent); > > - of_node_put(port); > > - } > > > -static int compare_of(struct device *dev, void *data) > > -{ > > - struct device_node *np = data; > > - > > - return dev->of_node == np; > > -} > > The original above passes port->parent to component_match_add(). This > means 'np' in the above compare_of() function is 'port->parent'. > > This means the above comparison is effectively: > > dev->of_node == port->parent > > The generic code instead does this: > > component_match_add(dev, &match, compare_of, port); > > So what we get in the comparison function is 'port' rather than > 'port->parent': > > > +static int compare_port(struct device *dev, void *data) > > { > > + struct device_node *np = data; > > + return dev->parent->of_node == np; > > +} > > which means the comparison is: > > dev->parent->of_node == port > > which is a different comparison from the above. > > You instead want this to be: > > return dev->of_node == np->parent; > > Heiko, please test the above change to compare_port() - I think you'll > find that will fix your issue. Sorry, I admit I'm not very good at doing patches without being able to test them. :( Thanks for helping on this! Liviu > > Thanks. > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/