From: Hartley Sweeten <HartleyS@visionengravers.com>
To: Ranjith Thangavel <ranjithece24@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "abbotti@mev.co.uk" <abbotti@mev.co.uk>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro
Thread-Topic: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro
Thread-Index: AQHRIJEMXpArvfCQq0abFX3Mty2M2Z6e5KFQ
Date: Mon, 16 Nov 2015 17:21:07 +0000
Message-ID: <BY1PR0101MB1063AE924FE9176CC041E78DD01E0@BY1PR0101MB1063.prod.exchangelabs.com>
References: <1447693764-7139-1-git-send-email-ranjithece24@gmail.com>
In-Reply-To: <1447693764-7139-1-git-send-email-ranjithece24@gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2015 17:21:07.0556
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0101MB1061
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1707
Lines: 46

On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index d312fda..9f8c9eb 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -508,7 +508,7 @@ static int dmm32at_reset(struct comedi_device *dev)
>  	outb(DMM32AT_CTRL_RESETA, dev->iobase + DMM32AT_CTRL_REG);
>  
>  	/* allow a millisecond to reset */
> -	udelay(1000);
> +	usleep_range(1000, 1050);
>  
>  	/* zero scan and fifo control */
>  	outb(0x0, dev->iobase + DMM32AT_FIFO_CTRL_REG);
> @@ -524,7 +524,7 @@ static int dmm32at_reset(struct comedi_device *dev)
>  	outb(DMM32AT_RANGE_U10, dev->iobase + DMM32AT_AI_CFG_REG);
>  
>  	/* should take 10 us to settle, here's a hundred */
> -	udelay(100);
> +	usleep_range(100, 150);
>  
>  	/* read back the values */
>  	ailo = inb(dev->iobase + DMM32AT_AI_LO_CHAN_REG);

Nothing in this patch uses the BIT macro.

Please make sure your commit messages actually match the patch.

You also posted a different patch on Saturday with the exact same commit message.

Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/