Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbKPRqt (ORCPT ); Mon, 16 Nov 2015 12:46:49 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:33815 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbbKPRqp (ORCPT ); Mon, 16 Nov 2015 12:46:45 -0500 MIME-Version: 1.0 In-Reply-To: <1447664207-24370-3-git-send-email-boris.brezillon@free-electrons.com> References: <1447664207-24370-1-git-send-email-boris.brezillon@free-electrons.com> <1447664207-24370-3-git-send-email-boris.brezillon@free-electrons.com> Date: Mon, 16 Nov 2015 18:46:44 +0100 Message-ID: Subject: Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate From: Joachim Eastwood To: Boris Brezillon Cc: Thierry Reding , linux-pwm@vger.kernel.org, Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors@lm-sensors.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input@vger.kernel.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Thomas Petazzoni , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Robert Jarzmik , Alexandre Belloni , Julia Lawall , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Ariel D'Alessandro" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2377 Lines: 82 Hi Boris (Adding Ariel for pwm-lpc18xx-sct) On 16 November 2015 at 09:56, Boris Brezillon wrote: > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. > Doing that will ease adaptation of the PWM framework to support atomic > update. > > Signed-off-by: Boris Brezillon > --- > Patch generated with the following coccinelle script: > > --->8--- > virtual patch > > @@ > struct pwm_device *p; > expression e; > @@ > ( > -(p)->polarity = e; > +pwm_set_polarity((p), e); > | > -(p)->polarity > +pwm_get_polarity((p)) > | > -(p)->period = e; > +pwm_set_period((p), e); > | > -(p)->period > +pwm_get_period((p)) > | > -(p)->duty_cycle = e; > +pwm_set_duty_cycle((p), e); > | > -(p)->duty_cycle > +pwm_get_duty_cycle((p)) > ) > --->8--- > --- > drivers/pwm/pwm-crc.c | 2 +- > drivers/pwm/pwm-lpc18xx-sct.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-crc.c b/drivers/pwm/pwm-crc.c > index 7101c70..2f88543 100644 > --- a/drivers/pwm/pwm-crc.c > +++ b/drivers/pwm/pwm-crc.c > @@ -75,7 +75,7 @@ static int crc_pwm_config(struct pwm_chip *c, struct pwm_device *pwm, > return -EINVAL; > } > > - if (pwm->period != period_ns) { > + if (pwm_get_period((pwm)) != period_ns) { > int clk_div; > > /* changing the clk divisor, need to disable fisrt */ > diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c > index 9163085..091fa13 100644 > --- a/drivers/pwm/pwm-lpc18xx-sct.c > +++ b/drivers/pwm/pwm-lpc18xx-sct.c > @@ -249,7 +249,7 @@ static int lpc18xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) > LPC18XX_PWM_EVSTATEMSK(lpc18xx_data->duty_event), > LPC18XX_PWM_EVSTATEMSK_ALL); > > - if (pwm->polarity == PWM_POLARITY_NORMAL) { > + if (pwm_get_polarity((pwm)) == PWM_POLARITY_NORMAL) { What is the deal with the double parentheses? Think I saw that in some of the other patches as well. regards, Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/