Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbbKPSUp (ORCPT ); Mon, 16 Nov 2015 13:20:45 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:60473 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbKPSUm (ORCPT ); Mon, 16 Nov 2015 13:20:42 -0500 Date: Mon, 16 Nov 2015 18:20:31 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: James Bottomley , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Hannes Reinecke , Matthew Wilcox , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH, resend] scsi: advansys: fix big-endian builds Message-ID: <20151116182031.GX8644@n2100.arm.linux.org.uk> References: <4411376.blKgWIg75B@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4411376.blKgWIg75B@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 17 On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > It turns out that the commit that introduced this used the cpu_to_le32() > incorrectly on an 8-bit field, which results in the sense_len to always > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper > byte of the 32-bit intermediate. More people need to run the sparse checker with -D__CHECK_ENDIAN__ and have proper endian annotations? -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/