Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279AbbKPSeO (ORCPT ); Mon, 16 Nov 2015 13:34:14 -0500 Received: from mga11.intel.com ([192.55.52.93]:31643 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbbKPSeL (ORCPT ); Mon, 16 Nov 2015 13:34:11 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,303,1444719600"; d="scan'208";a="852047894" Date: Mon, 16 Nov 2015 11:34:04 -0700 From: Ross Zwisler To: Dan Williams Cc: Yigal Korman , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , Linux MM , linux-fsdevel , david , Andrew Morton , Stable Tree , Boaz Harrosh , Ross Zwisler , Alexander Viro , Dave Chinner , Jan Kara , "Kirill A. Shutemov" , Matthew Wilcox Subject: Re: [PATCH] mm, dax: fix DAX deadlocks (COW fault) Message-ID: <20151116183404.GA22996@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dan Williams , Yigal Korman , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , Linux MM , linux-fsdevel , david , Andrew Morton , Stable Tree , Boaz Harrosh , Alexander Viro , Dave Chinner , Jan Kara , "Kirill A. Shutemov" , Matthew Wilcox References: <1447675755-5692-1-git-send-email-yigal@plexistor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3080 Lines: 70 On Mon, Nov 16, 2015 at 10:15:56AM -0800, Dan Williams wrote: > On Mon, Nov 16, 2015 at 4:09 AM, Yigal Korman wrote: > > DAX handling of COW faults has wrong locking sequence: > > dax_fault does i_mmap_lock_read > > do_cow_fault does i_mmap_unlock_write > > > > Ross's commit[1] missed a fix[2] that Kirill added to Matthew's > > commit[3]. > > > > Original COW locking logic was introduced by Matthew here[4]. > > > > This should be applied to v4.3 as well. > > > > [1] 0f90cc6609c7 mm, dax: fix DAX deadlocks > > [2] 52a2b53ffde6 mm, dax: use i_mmap_unlock_write() in do_cow_fault() > > [3] 843172978bb9 dax: fix race between simultaneous faults > > [4] 2e4cdab0584f mm: allow page fault handlers to perform the COW > > > > Signed-off-by: Yigal Korman > > > > Cc: Stable Tree > > Cc: Boaz Harrosh > > Cc: Ross Zwisler > > Cc: Alexander Viro > > Cc: Dan Williams > > Cc: Dave Chinner > > Cc: Jan Kara > > Cc: "Kirill A. Shutemov" > > Cc: Matthew Wilcox > > --- > > mm/memory.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index c716913..e5071af 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -3015,9 +3015,9 @@ static int do_cow_fault(struct mm_struct *mm, struct vm_area_struct *vma, > > } else { > > /* > > * The fault handler has no page to lock, so it holds > > - * i_mmap_lock for write to protect against truncate. > > + * i_mmap_lock for read to protect against truncate. > > */ > > - i_mmap_unlock_write(vma->vm_file->f_mapping); > > + i_mmap_unlock_read(vma->vm_file->f_mapping); > > } > > goto uncharge_out; > > } > > @@ -3031,9 +3031,9 @@ static int do_cow_fault(struct mm_struct *mm, struct vm_area_struct *vma, > > } else { > > /* > > * The fault handler has no page to lock, so it holds > > - * i_mmap_lock for write to protect against truncate. > > + * i_mmap_lock for read to protect against truncate. > > */ > > - i_mmap_unlock_write(vma->vm_file->f_mapping); > > + i_mmap_unlock_read(vma->vm_file->f_mapping); > > } > > return ret; > > uncharge_out: > > Looks good to me. I'll include this with some other DAX fixes I have pending. Looks good to me as well. Thanks for catching this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/