Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbbKPSfI (ORCPT ); Mon, 16 Nov 2015 13:35:08 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:47783 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbbKPSfF (ORCPT ); Mon, 16 Nov 2015 13:35:05 -0500 Date: Mon, 16 Nov 2015 10:35:01 -0800 From: Christoph Hellwig To: Russell King - ARM Linux Cc: Arnd Bergmann , James Bottomley , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Hannes Reinecke , Matthew Wilcox , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH, resend] scsi: advansys: fix big-endian builds Message-ID: <20151116183501.GA25744@infradead.org> References: <4411376.blKgWIg75B@wuerfel> <20151116182031.GX8644@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151116182031.GX8644@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 17 On Mon, Nov 16, 2015 at 06:20:31PM +0000, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: > > It turns out that the commit that introduced this used the cpu_to_le32() > > incorrectly on an 8-bit field, which results in the sense_len to always > > be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper > > byte of the 32-bit intermediate. > > More people need to run the sparse checker with -D__CHECK_ENDIAN__ and > have proper endian annotations? Ho about enabling __CHECK_ENDIAN__ by default when running sparse at least? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/