Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbbKPS4H (ORCPT ); Mon, 16 Nov 2015 13:56:07 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36718 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbbKPS4E (ORCPT ); Mon, 16 Nov 2015 13:56:04 -0500 MIME-Version: 1.0 In-Reply-To: <20151116182031.GX8644@n2100.arm.linux.org.uk> References: <4411376.blKgWIg75B@wuerfel> <20151116182031.GX8644@n2100.arm.linux.org.uk> Date: Mon, 16 Nov 2015 19:56:03 +0100 X-Google-Sender-Auth: NmoCaW2GUgug1GJ9kKoCduB0Iww Message-ID: Subject: Re: [PATCH, resend] scsi: advansys: fix big-endian builds From: Geert Uytterhoeven To: Russell King - ARM Linux Cc: Arnd Bergmann , James Bottomley , scsi , "Martin K. Petersen" , "linux-kernel@vger.kernel.org" , Hannes Reinecke , Matthew Wilcox , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 31 On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux wrote: > On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote: >> It turns out that the commit that introduced this used the cpu_to_le32() >> incorrectly on an 8-bit field, which results in the sense_len to always >> be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper >> byte of the 32-bit intermediate. > > More people need to run the sparse checker with -D__CHECK_ENDIAN__ and > have proper endian annotations? Sure. But in this case, it shows up as a normal compiler warning on all big endian platforms. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/