Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbbKPUxb (ORCPT ); Mon, 16 Nov 2015 15:53:31 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41289 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbbKPUx3 (ORCPT ); Mon, 16 Nov 2015 15:53:29 -0500 Date: Mon, 16 Nov 2015 15:53:27 -0500 (EST) Message-Id: <20151116.155327.1432148371996261050.davem@davemloft.net> To: mans@mansr.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller From: David Miller In-Reply-To: <1447698216-7635-1-git-send-email-mans@mansr.com> References: <1447698216-7635-1-git-send-email-mans@mansr.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Nov 2015 12:53:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 24 From: Mans Rullgard Date: Mon, 16 Nov 2015 18:23:35 +0000 > +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) "i" is passed in as a signed int here, but: > +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) ... > + err = nb8800_alloc_rx(dev, i, true); It comes from an 'unsigned' value. Please pick one type and use it consistently. Also, always fully spell out "unsigned int" rather than use "unsigned" as a shorthand. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/