Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbbKPU73 (ORCPT ); Mon, 16 Nov 2015 15:59:29 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:42148 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752508AbbKPU70 convert rfc822-to-8bit (ORCPT ); Mon, 16 Nov 2015 15:59:26 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: David Miller Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller References: <1447698216-7635-1-git-send-email-mans@mansr.com> <20151116.155327.1432148371996261050.davem@davemloft.net> Date: Mon, 16 Nov 2015 20:59:18 +0000 In-Reply-To: <20151116.155327.1432148371996261050.davem@davemloft.net> (David Miller's message of "Mon, 16 Nov 2015 15:53:27 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 878 Lines: 34 David Miller writes: > From: Mans Rullgard > Date: Mon, 16 Nov 2015 18:23:35 +0000 > >> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi) > > "i" is passed in as a signed int here, but: > >> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len) > ... >> + err = nb8800_alloc_rx(dev, i, true); > > It comes from an 'unsigned' value. > > Please pick one type and use it consistently. Darn, missed one. > Also, always fully spell out "unsigned int" rather than use "unsigned" > as a shorthand. OK Anything else? -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/