Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbbKPVgO (ORCPT ); Mon, 16 Nov 2015 16:36:14 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:37192 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752460AbbKPVgM (ORCPT ); Mon, 16 Nov 2015 16:36:12 -0500 Subject: Re: leds-bcm6328: add more init configuration options To: Jacek Anaszewski , Simon Arlott References: <5648C090.9060904@simon.arlott.org.uk> <5649F040.6090002@samsung.com> Cc: linux-leds@vger.kernel.org, Linux Kernel Mailing List , devicetree@vger.kernel.org From: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= Message-ID: <564A4C3B.6090806@gmail.com> Date: Mon, 16 Nov 2015 22:35:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5649F040.6090002@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 52 Hi Simon and Jacek, This is done on purpose because not every BCM63268 device has serial LEDs and we should be able to enable/disable those options in order to avoid depending on the bootloader setting the registers correctly. Regards, Álvaro. El 16/11/2015 a las 16:03, Jacek Anaszewski escribió: > Hi Simon, > > On 11/15/2015 06:27 PM, Simon Arlott wrote: >> commit 1d3ff22d633d35048c35c3deeead7ab116cebc32 >> Author: Álvaro Fernández Rojas >> Date: Thu Oct 8 12:35:55 2015 +0200 >> >> Documentation: leds: update DT bindings for leds-bcm6328 >> >> This patch adds latest DT bindings for leds-bcm6328 init register >> configuration. >> >> commit 9f82c778ce17789a038351a411ff65cd41033c7a >> Author: Álvaro Fernández Rojas >> Date: Thu Oct 8 12:35:54 2015 +0200 >> >> leds-bcm6328: add more init configuration options >> >> This patch adds more init register configuration options: >> - Serial LEDs multiplexing. >> - Serial LEDs clock signal low/high polarity. >> - Serial LEDs data signal low/high polarity. >> - Serial LEDs shift direction inverted/normal. >> >> This was not a backwards-compatible change, because the driver is now >> turning off all of the serial LED options by default when previously >> it only turned off brcm,serial-leds and left the other options >> unchanged. >> >> There are currently no in-tree users of this binding, so any existing >> users will be broken by this change. >> > > Please submit a patch fixing the issue in such cases, so that we could > discuss possible solutions to the problem. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/