Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbKPWjU (ORCPT ); Mon, 16 Nov 2015 17:39:20 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:32930 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbbKPWjT (ORCPT ); Mon, 16 Nov 2015 17:39:19 -0500 Date: Mon, 16 Nov 2015 22:39:02 +0000 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Greg Kroah-Hartman , Alexander Shishkin , Mathieu Poirier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] stm: select CONFIG_SRCU Message-ID: <20151116223902.GO8644@n2100.arm.linux.org.uk> References: <12747713.N26XusNZpW@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12747713.N26XusNZpW@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 34 On Mon, Nov 16, 2015 at 10:14:35PM +0100, Arnd Bergmann wrote: > The newly added STM code uses SRCU, but does not ensure that > this code is part of the kernel: > > drivers/built-in.o: In function `stm_source_link_show': > include/linux/srcu.h:221: undefined reference to `__srcu_read_lock' > include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock' > drivers/built-in.o: In function `stm_source_link_drop': > include/linux/srcu.h:221: undefined reference to `__srcu_read_lock' > include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock' > > This adds a Kconfig 'select' statement like all the other SRCU using > drivers have. > > Signed-off-by: Arnd Bergmann > Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices") Related to this, I have to ask why if I answer to N to STM, I'm then presented with the STM driver options in this file. It's not like they'll be built, as drivers/Makefile has: obj-$(CONFIG_STM) += hwtracing/stm/ so it seems rather pointless.. Maybe the other options here should be wrapped with if STM..endif ? -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/