Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752386AbbKPWuw (ORCPT ); Mon, 16 Nov 2015 17:50:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42752 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbKPWuu (ORCPT ); Mon, 16 Nov 2015 17:50:50 -0500 Subject: Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro To: Ard Biesheuvel , Laura Abbott References: <1447359670-23652-1-git-send-email-labbott@fedoraproject.org> Cc: Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" From: Laura Abbott Message-ID: <564A5DC8.9090307@redhat.com> Date: Mon, 16 Nov 2015 14:50:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 31 On 11/14/2015 11:38 PM, Ard Biesheuvel wrote: > On 12 November 2015 at 21:21, Laura Abbott wrote: >> The permissions in mark_rodata_ro trigger a build error >> with STRICT_MM_TYPECHECKS. Fix this by introducing >> PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO. > > Forgive the bikeshedding but perhaps PAGE_KERNEL_EXEC_RO is more consistent? > powerpc was using PAGE_KERNEL_ROX so I went with that. Blame powerpc ;) >> From Ard: >> >> "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range >> writeable under the ARMv8.1 DBM feature, that manages the >> dirty bit in hardware (writing to a page with the PTE_RDONLY >> and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)" >> >> Signed-off-by: Laura Abbott > > Acked-by: Ard Biesheuvel > Thanks, Laura -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/