Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbbKPXqj (ORCPT ); Mon, 16 Nov 2015 18:46:39 -0500 Received: from icp-osb-irony-out4.external.iinet.net.au ([203.59.1.220]:39000 "EHLO icp-osb-irony-out4.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbbKPXqh (ORCPT ); Mon, 16 Nov 2015 18:46:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjQCANxpSlZnMNI1/2dsb2JhbAANUIR9q1sBAQEBAQEGkGCEDYYQAoITAQEBAQEBhUABAQQjVQEQCw0LAgIFFgsCAgkDAgECAUUGDQYCAQGyKnGQOAEBAQEBAQEDAQEBAQEegQGFDIVFh3WBRAWWSY8Ch1mFeIkng3KCdB0WgVJghQoBAQE X-IronPort-AV: E=Sophos;i="5.20,304,1444665600"; d="scan'208";a="27334015" Subject: Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn To: Geert Uytterhoeven References: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> <1447585455-19671-5-git-send-email-geert@linux-m68k.org> <5649C987.3050600@uclinux.org> Cc: Sam Creasey , linux-m68k , Linux-Arch , "linux-kernel@vger.kernel.org" From: Greg Ungerer Message-ID: <564A6AD9.6010307@uclinux.org> Date: Tue, 17 Nov 2015 09:46:33 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 50 Hi Geert, On 16/11/15 23:05, Geert Uytterhoeven wrote: > On Mon, Nov 16, 2015 at 1:18 PM, Greg Ungerer wrote: >>> --- a/arch/m68k/kernel/setup_no.c >>> +++ b/arch/m68k/kernel/setup_no.c >>> @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) >>> * Give all the memory to the bootmap allocator, tell it to put >>> the >>> * boot mem_map at the start of memory. >>> */ >>> + min_low_pfn = PFN_DOWN(memory_start); >>> + max_pfn = max_low_pfn = PFN_DOWN(memory_end); >>> + >>> bootmap_size = init_bootmem_node( >>> NODE_DATA(0), >>> - memory_start >> PAGE_SHIFT, /* map goes here */ >>> - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire >>> */ >>> - memory_end >> PAGE_SHIFT); >>> + min_low_pfn, /* map goes here */ >>> + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */ >>> + max_pfn); >>> /* >>> * Free the usable memory, we have to make sure we do not free >>> * the bootmem bitmap so we then reserve it after freeing it :-) >> >> Should this be changed to use init_bootmem() as per your changes >> in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and >> {min,max}_low_pfn")? For the same reason? > > No. PAGE_OFFSET = PAGE_OFFSET_RAW = CONFIG_RAMBASE. > As the comment says, this is zero on coldfire, but not on all m68knommu > platforms. > > Upon closer look, this isn't even true on all Coldfire boards: > > arch/m68k/configs/m5208evb_defconfig:CONFIG_RAMBASE=0x40000000 Yes, that comment is definitely wrong! Regards Greg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/