Date: Mon, 16 Nov 2015 16:09:10 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        John Stultz <john.stultz@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>,
        Josh Triplett <josh@joshtriplett.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 2/4] timer: relax tick stop in idle entry
Message-ID: <20151116160910.3811c8ca@icelake>
In-Reply-To: <alpine.DEB.2.11.1511162255430.3761@nanos>
References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1447444387-23525-3-git-send-email-jacob.jun.pan@linux.intel.com>
	<alpine.DEB.2.11.1511131516180.3987@nanos>
	<20151113142438.3144d47d@icelake>
	<alpine.DEB.2.11.1511161558550.3761@nanos>
	<20151116135126.5a50e45d@icelake>
	<alpine.DEB.2.11.1511162255430.3761@nanos>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 847
Lines: 25

On Mon, 16 Nov 2015 23:01:12 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:

> > For the second case, which is much more rare, I think we do have
> > next timer exactly one tick away. Just don't know why tick will
> > continue into idle loop.  
> 
> Well, it should not be hard to figure that out. There are not so many
> checks involved when tick_nohz_irq_exit() is called.
Thanks for the tip, I found the cause is in 
int idle_cpu(int cpu)
{
	if (rq->nr_running)
		return 0;

Since we only take into account of cfs_rq runnable taking over
cfs_rq->nr_running when forced_idle is set.


Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/