Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbbKQCkP (ORCPT ); Mon, 16 Nov 2015 21:40:15 -0500 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:3863 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbbKQCkN (ORCPT ); Mon, 16 Nov 2015 21:40:13 -0500 X-RM-TRANSID: 2ee5564a938a830-0ef9c X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee7564a93894db-f1868 Date: Tue, 17 Nov 2015 10:40:01 +0800 From: Yaowei Bai To: Michal Hocko Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, rientjes@google.com, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm/mmzone: refactor memmap_valid_within Message-ID: <20151117024001.GC5867@yaowei-K42JY> References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-8-git-send-email-baiyaowei@cmss.chinamobile.com> <20151116124501.GF14116@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151116124501.GF14116@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 43 On Mon, Nov 16, 2015 at 01:45:01PM +0100, Michal Hocko wrote: > On Mon 16-11-15 14:51:26, Yaowei Bai wrote: > [...] > > @@ -72,16 +72,10 @@ struct zoneref *next_zones_zonelist(struct zoneref *z, > > } > > > > #ifdef CONFIG_ARCH_HAS_HOLES_MEMORYMODEL > > -int memmap_valid_within(unsigned long pfn, > > +bool memmap_valid_within(unsigned long pfn, > > struct page *page, struct zone *zone) > > { > > - if (page_to_pfn(page) != pfn) > > - return 0; > > - > > - if (page_zone(page) != zone) > > - return 0; > > - > > - return 1; > > + return page_to_pfn(page) == pfn && page_zone(page) == zone; > > I do not think this is easier to read. Quite contrary OK, so we can just make it return ture/false without refactoring it. > > > } > > #endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */ > > > > -- > > 1.9.1 > > > > > > -- > Michal Hocko > SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/