Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbKQDSz (ORCPT ); Mon, 16 Nov 2015 22:18:55 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34308 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbbKQDSv (ORCPT ); Mon, 16 Nov 2015 22:18:51 -0500 Message-ID: <564A9C54.3090904@linaro.org> Date: Tue, 17 Nov 2015 11:17:40 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Zhou Wang , Arnd Bergmann CC: linux-arm-kernel@lists.infradead.org, Jisheng Zhang , bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: hisi: fix deferred probing References: <1447329728-1589-1-git-send-email-jszhang@marvell.com> <4417267.EzK5DAjM5p@wuerfel> <56459149.8090709@hisilicon.com> In-Reply-To: <56459149.8090709@hisilicon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 33 On 11/13/2015 03:29 PM, Zhou Wang wrote: > On 2015/11/12 20:21, Arnd Bergmann wrote: >> The hisi_pcie_probe function is incorrectly marked as __init, as Kconfig >> tells us: >> >> WARNING: drivers/pci/host/built-in.o(.data+0x7780): Section mismatch in reference from the variable hisi_pcie_driver to the function .init.text:hisi_pcie_probe() >> >> If the probe for this device gets deferred past the point where __init >> functions are removed, or the device is unbound and then reattached to >> the driver, we branch into uninitialized memory, which is bad. >> >> This removes the __init annotation. >> >> Signed-off-by: Arnd Bergmann >> > > Hi Arnd, > > Many thanks, it looks good to me. so > Acked-by: Zhou Wang I found this problem too and prepared a patch for it, but I noticed that Arnd already fixed it :) Reviewed-by: Hanjun Guo Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/