Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbbKQEOG (ORCPT ); Mon, 16 Nov 2015 23:14:06 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34259 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbbKQEOC (ORCPT ); Mon, 16 Nov 2015 23:14:02 -0500 Date: Mon, 16 Nov 2015 20:13:58 -0800 From: Eduardo Valentin To: Arnd Bergmann Cc: Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Ivan T. Ivanov" , David Collins , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] Revert "thermal: qcom_spmi: allow compile test" Message-ID: <20151117041357.GC27415@localhost.localdomain> References: <9183915.mBPRJBbpGR@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9183915.mBPRJBbpGR@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1799 Lines: 46 On Mon, Nov 16, 2015 at 10:43:50PM +0100, Arnd Bergmann wrote: > This just caused build errors: > > warning: (QCOM_SPMI_TEMP_ALARM) selects REGMAP_SPMI which has unmet direct dependencies (SPMI) > drivers/built-in.o: In function `regmap_spmi_ext_gather_write': > :(.text+0x609b0): undefined reference to `spmi_ext_register_write' > :(.text+0x609f0): undefined reference to `spmi_ext_register_writel' > > While it's generally a good idea to allow compile testing, in this > case, it just doesn't work, so reverting the patch that > introduced the compile-test variant seems the most appropriate > solution. Looking this closer, the original patch simply does not make sense. The platform dependent code is already covered by the SPMI code. > > Note that SPIMI also has a 'depends on ARCH_QCOM || COMPILE_TEST' > statement, so we should be able to enable SPMI on all architectures > for compile testing already. So, applied. I just s/SPIMI/SPMI/g. > > Signed-off-by: Arnd Bergmann > Fixes: cb7fb4d34202 ("thermal: qcom_spmi: allow compile test") > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 2e7524f0f3f7..6045b17d0e00 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -381,7 +381,7 @@ endmenu > > config QCOM_SPMI_TEMP_ALARM > tristate "Qualcomm SPMI PMIC Temperature Alarm" > - depends on OF && (SPMI || COMPILE_TEST) && IIO > + depends on OF && SPMI && IIO > select REGMAP_SPMI > help > This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/